On branch edburns/11556-duplicate-closing-punctuation-in-compiler-mes… #11557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sages modified: substratevm/src/com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/SerialGCOptions.java modified: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/SubstrateOptions.java modified: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/configure/ConfigurationFiles.java modified: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/option/RuntimeOptionParser.java modified: substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/NativeImageOptions.java modified: substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/jdk/localization/LocalizationFeature.java modified: truffle/src/com.oracle.truffle.api.test/src/com/oracle/truffle/api/test/option/OptionProcessorTest.java modified: truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/PolyglotEngineOptions.java modified: wasm/src/org.graalvm.wasm/src/org/graalvm/wasm/WasmOptions.java - The party doing the interpolation is responsible for the closing punctuation, not the source of the interpolated text. Signed-off-by: Ed Burns <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
1 task
|
Thanks for the PR! Any way you could add a test to avoid these problems in the future? |
…sages modified: truffle/src/com.oracle.truffle.api/src/com/oracle/truffle/api/Option.java Document that authors of `deprecationMessage` values must not include closing punctuation. Signed-off-by: Ed Burns <[email protected]>
…sages modified: truffle/src/com.oracle.truffle.api.test/src/com/oracle/truffle/api/test/option/OptionProcessorTest.java @fniephaus wrote: > Any way you could add a test to avoid these problems in the future? Signed-off-by: Ed Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sages
modified: substratevm/src/com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/SerialGCOptions.java
modified: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/SubstrateOptions.java
modified: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/configure/ConfigurationFiles.java
modified: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/option/RuntimeOptionParser.java
modified: substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/NativeImageOptions.java
modified: substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/jdk/localization/LocalizationFeature.java
modified: truffle/src/com.oracle.truffle.api.test/src/com/oracle/truffle/api/test/option/OptionProcessorTest.java
modified: truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/PolyglotEngineOptions.java
modified: wasm/src/org.graalvm.wasm/src/org/graalvm/wasm/WasmOptions.java