feat #388: Add support for paravirtualized launch volume attachment #395
Conversation
1.updated tilt image golang version to 1.21.8 2.added bash to kustomize-sub.sh call Signed-off-by: Mayank Kakani <[email protected]>
Added LaunchParavirtualizedVolumeAttachment types to v1
added LaunchParavirtualizedVolumeAttachment type
Added support for getParavirtualizedVolumeAttachment
added launchParavirtualizedVolumeAttachment defination
added launchParavirtualizedVolumeAttachment definations
Updated OCI go sdk version to v65.81.1 to support paravirtualized volume
Updated OCI SDK version
added test for paravirtualized volumes
Update machine_test.go
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
| } else if attachment.Type == infrastructurev1beta2.ParavirtualizedType { | ||
| volumes = append(volumes, getParavirtualizedVolumeAttachment(attachment.ParavirtualizedAttachment)) | ||
| } else { | ||
| m.Logger.Info("Block Volume attachment type not supported") |
There was a problem hiding this comment.
Lets change this to "Unknown attachment type not supported" or something like that
| @@ -551,6 +551,102 @@ func TestInstanceReconciliation(t *testing.T) { | |||
| OpcRetryToken: ociutil.GetOPCRetryToken("machineuid")})).Return(core.LaunchInstanceResponse{}, nil) | |||
| }, | |||
| }, | |||
| { | |||
| name: "check all params together, with subnet id set, nsg id list", | |||
| }, | ||
| AvailabilityDomain: common.String("ad2"), | ||
| CompartmentId: common.String("test"), | ||
| IsPvEncryptionInTransitEnabled: common.Bool(true), |
There was a problem hiding this comment.
we should probably have a test that doesn't set things that are nullable
|
I'm currently running the e2e tests on this PR. Do you mind outputting the unit test output like we do for the other landed PRs? |
|
I've fun the e2e tests We will need the following still
|
feat Add support for paravirtualized launch volume attachment
What this PR does / why we need it:
Recently support was added for configuring paravirtualized launch volume attachments at instance creation with go sdk v65.75.1 onwards, added the support for attaching paravirtualized volume at instance creation via cluster api provider.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged): #388Fixes #
Updated OCI Go sdk version to v65.81.1
Updated tilt-helper docker manifest go version to 1.21.8
added support for paravirtualized volumes
Signed-off-by: Mayank Kakani [email protected]