Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running action with ARM64 machines #64

Closed
wants to merge 1 commit into from

Conversation

vlsi
Copy link

@vlsi vlsi commented Nov 27, 2023

Try JAVA_HOME_17_ARM64 first, and fallback to JAVA_HOME_17_X86

Fixes #63

Try JAVA_HOME_17_ARM64 first, and fallback to JAVA_HOME_17_X86

Fixes oracle-actions#63
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Nov 27, 2023
@vlsi
Copy link
Author

vlsi commented Nov 27, 2023

@sormuras it looks like I forgot to include my GitHub username when filing CLA. Do you think you could help me with adding my GitHub id to the Oracle CLA?

Here's my OpenJDK id: https://openjdk.org/census#vsitnikov

https://oca.opensource.oracle.com/?ojr=faq
Why should I provide my GitHub username in the OCA?
... If you forgot to put your GitHub username on the OCA when filing it, please reach out to project maintainers (e.g., through comments on your GitHub PR, Slack channels, or mailing lists) who can add it for you.

@sormuras
Copy link
Member

Hi Vladimir, I started the runs and also asked (how) to connect your GH username to CLA - let's wait and see what happens.

@robilad
Copy link

robilad commented Nov 27, 2023

Hi, in order to get your account verified, please send me an e-mail directly at [email protected]

@sormuras sormuras changed the title feat: support running action with ARM64 machines Support running action with ARM64 machines Nov 30, 2023
@sormuras
Copy link
Member

sormuras commented Dec 4, 2023

Any news on the OCA here?

@sormuras
Copy link
Member

sormuras commented Dec 4, 2023

I skimmed https://github.com/actions/runner-images#available-images and found only an ARM architecture mentioned here: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-arm64-Readme.md#java as for example JAVA_HOME_17_arm64

Note: it ends with a lower-case arm64.

  • Would the suggested change also work on macos-13-arm64 machines?
  • What if there was a Windows running on ARM? Wouldn't a test for java.exe be required in if [ ! -f "$JAVA" ]; then?

@vlsi
Copy link
Author

vlsi commented Dec 4, 2023

See also: actions/setup-java#561

@sureshg
Copy link

sureshg commented Feb 1, 2024

Can we merge this change as M1 mac runner is available for general public now?

@sormuras
Copy link
Member

sormuras commented Feb 1, 2024

This PR and your PR #71 lack an OCA approval. I'll talk to @robilad how to follow-up on this.

sormuras added a commit that referenced this pull request Feb 1, 2024
@sormuras sormuras closed this in c9a099b Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.
Development

Successfully merging this pull request may close these issues.

Action fails at aarch64 machine since action.yml hardcodes X64
4 participants