Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the algo selection tool #550

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Polish the algo selection tool #550

merged 8 commits into from
Nov 13, 2024

Conversation

janosg
Copy link
Member

@janosg janosg commented Nov 12, 2024

  • Create a better string representation for algorithm classes
  • Allow algorithm classes and instances as dict keys in the results dict for criterion_plot

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/optimagic/optimization/algorithm.py 80.00% 4 Missing ⚠️
src/optimagic/optimizers/pygmo_optimizers.py 33.33% 2 Missing ⚠️
src/optimagic/optimizers/tao_optimizers.py 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/estimagic/__init__.py 96.36% <ø> (-0.31%) ⬇️
src/optimagic/__init__.py 100.00% <ø> (ø)
src/optimagic/algorithms.py 85.68% <100.00%> (+0.10%) ⬆️
src/optimagic/visualization/history_plots.py 90.72% <100.00%> (+0.80%) ⬆️
src/optimagic/optimizers/pygmo_optimizers.py 94.48% <33.33%> (-0.49%) ⬇️
src/optimagic/optimizers/tao_optimizers.py 74.28% <33.33%> (-1.68%) ⬇️
src/optimagic/optimization/algorithm.py 94.79% <80.00%> (-1.77%) ⬇️

@janosg janosg requested a review from timmens November 12, 2024 18:25
@timmens timmens self-requested a review November 13, 2024 14:45
@timmens timmens merged commit 84be118 into main Nov 13, 2024
22 checks passed
@timmens timmens deleted the algo-repr branch November 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants