Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which Optimizer to Choose #536

Merged
merged 31 commits into from
Nov 5, 2024
Merged

Which Optimizer to Choose #536

merged 31 commits into from
Nov 5, 2024

Conversation

mpetrosian
Copy link
Member

@mpetrosian mpetrosian commented Oct 4, 2024

Update the how_to_algorithm_selection notebook to include guidelines for algorithm selection based on theory.

  • Add decision tree based on problem properties
  • Add introduction on the process of algorithm selection
  • Add example code for each step of algorithm selection using a function from the More-Wild benchmark set

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

Copy link
Member

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat! Just textual changes / a bit of structure.

docs/source/how_to/index.md Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@ChristianZimpelmann ChristianZimpelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot!

Some small comments and an idea how to simplify the structure below.

docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
docs/source/how_to/how_to_algorithm_selection.ipynb Outdated Show resolved Hide resolved
@janosg janosg removed the request for review from timmens November 4, 2024 16:22
@janosg
Copy link
Member

janosg commented Nov 5, 2024

Thanks @ChristianZimpelmann and @hmgaudecker for the feedback. I think this made the guide much clearer!

@janosg janosg merged commit 7cb7710 into main Nov 5, 2024
17 checks passed
@janosg janosg deleted the how_to_algo_selection branch November 5, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants