Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.0 [WIP] #501

Merged
merged 17 commits into from
Aug 22, 2024
Merged

Release 0.5.0 [WIP] #501

merged 17 commits into from
Aug 22, 2024

Conversation

janosg
Copy link
Member

@janosg janosg commented Jul 10, 2024

Release 0.5.0 will bring several breaking changes and deprecations. On a high level, the major changes are:

  • Implement EP-02: Static typing
  • Implement EP-03: Alignment with SciPy
  • Rename the package from estimagic to optimagic (while keeping the estimagic
    namespace for the estimation capabilities).

This branch will stay open until all changes are implemented. The actual changes are implemented as PRs on this branch. In the end we will merge this PR without squashing commits.

We roughly have the following things to do:

Renaming

  • Rename and restructure the package
  • Rename and restructure the documentation
  • Add infrastructure to release under two names

Alignment

  • Align the argument names of minimize and maximize with scipy
  • Introduce aliases
  • Rename algo-options

Typing

  • Implement new objective function interface
  • Implement new bounds interface
  • Implement new constraints interface
  • Implement new internal algorithm interface
  • Implement unfiltered algorithm selection and make issue for filtered algorithm selection (postponed because not a breaking change)
  • Implement new algo-options interfaces (postponed because not a breaking change)
  • Implement new interface for custom derivatives
  • Implement jax autodiff (postponed because not a breaking change)
  • Implement new logging
  • Implement new scaling interface
  • Implement new multistart interface
  • Improve numerical differentiation
  • Replace other option dictionaries by option objects
  • Implement new benchmarking interface and architecture (postponed; there will be deprecations coming but this is not a widely used feature)
  • Make adjustments for estimation functions

Documentation

  • Write a completely new docstring for minimize and maximize (I deleted the old one instead of making mini updates all the time)
  • Go over all code snippets and notebooks in the documentation and make sure they use recommended interfaces

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@janosg janosg added the WIP Work in progress label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 94.32990% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.51%. Comparing base (ef92f4f) to head (43f8488).
Report is 18 commits behind head on main.

Files Patch % Lines
src/estimagic/estimate_ml.py 89.06% 7 Missing ⚠️
src/estimagic/__init__.py 96.22% 2 Missing ⚠️
src/estimagic/estimate_msm.py 97.61% 1 Missing ⚠️
src/estimagic/examples/logit.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   93.08%   92.51%   -0.57%     
==========================================
  Files         195      109      -86     
  Lines       14718    11778    -2940     
==========================================
- Hits        13700    10897    -2803     
+ Misses       1018      881     -137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosg janosg changed the base branch from main to update-roadmap August 10, 2024 08:24
@janosg janosg changed the base branch from update-roadmap to main August 10, 2024 08:24
Copy link
Member

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow.

@janosg janosg merged commit caeb370 into main Aug 22, 2024
16 checks passed
@timmens timmens deleted the 0.5.0 branch August 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants