Skip to content

fix(backend): add database version check on startup #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

fatih-acar
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jun 16, 2025
Copy link

codspeed-hq bot commented Jun 16, 2025

CodSpeed Performance Report

Merging #6712 will not alter performance

Comparing fac-neo4j-version-check (20619a6) with stable (f104718)

Summary

✅ 10 untouched benchmarks

@@ -47,6 +47,8 @@

log = get_logger()

SUPPORTED_DATABASE_VERSION = "Neo4j/2025.03"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's relevant at this moment but potentially this could be a property of class DatabaseType if we want to do another try with Memgraph.

Copy link
Contributor Author

@fatih-acar fatih-acar Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's a bit quick and dirty, but better than nothing I guess.
For Memgraph, I don't know if we expect to support it back soon... my opinion is to not put effort on Memgraph yet...
I'll move that to a property as you suggested, it should be straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants