Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username support to incident.Responder struct #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add username support to incident.Responder struct #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions incident/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package incident

import (
"fmt"
"net/http"
"strconv"
"strings"
Expand Down Expand Up @@ -803,21 +804,35 @@ const (
)

type Responder struct {
Type ResponderType `json:"type,omitempty"`
Name string `json:"name,omitempty"`
Id string `json:"id,omitempty"`
Type ResponderType `json:"type,omitempty"`
Name string `json:"name,omitempty"`
Username string `json:"username,omitempty"`
Id string `json:"id,omitempty"`
}

func validateResponders(responders []Responder) error {
for _, responder := range responders {
if responder.Type == "" {
return errors.New("Responder type cannot be empty.")
}
if !(responder.Type == User || responder.Type == Team) {
return errors.New("Responder type should be one of these: 'User', 'Team'.")
}
if responder.Name == "" && responder.Id == "" {
return errors.New("For responder either name or id must be provided.")
switch responder.Type {
case Team:
if responder.Username != "" {
return errors.New("For team responders, username must not be set")
}

if responder.Name == "" && responder.Id == "" {
return errors.New("For team responders either name or id must be provided.")
}

case User:
if responder.Name != "" {
return errors.New("For user responders, name must not be set")
}

if responder.Username == "" && responder.Id == "" {
return errors.New("For user responders either username or id must be provided.")
}

default:
return errors.New(fmt.Sprintf("Unsupported responder type %s", responder.Type))
}
}
return nil
Expand Down