Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Support for behind web proxy #39 #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ibre5041
Copy link

@ibre5041 ibre5041 commented Sep 14, 2022

This RP addresses these issues:

  • Support for behind web proxy Support for behind web proxy #39, The core of application already works fine behind proxy, but accessing rete-limit API does not respect JVM proxy setting

  • Log4j version was upgraded to 2.17.2

  • Source and Target version was upgraded to Java 1.8

  • Last patch is workaround for faulty RateLimitManager.getApiLimitForDomain(...) returns 0 for threadCount and then following line:

      pool = Executors.newFixedThreadPool(threadCount);
    

throws IllegalArgumentException.

@vojtechDB
Copy link

proxy setting could be used if this PR would be merged in this way:

java -Dhttp.nonProxyHosts="github.mycompany.com" -Dhttps.proxyHost=192.168.100.1 -Dhttps.proxyPort=8080 -jar OpsGenieExportUtil-0.xx.xx.jar .......

@sampath-kolisetty
Copy link
Contributor

@ibre5041 @vojtechDB Please update your branch with latest master and resolve conflicts.

@vojtechDB
Copy link

@sampath-kolisetty new PR with solved conflict created #55

@idi2022
Copy link

idi2022 commented Jan 25, 2023

Hello, @sampath-kolisetty @@ibre5041 @vojtechDB
and thanks for all the edits
can we know when we will have the new version because we are blocked by the proxy from ni internal gitlab
thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants