This repository was archived by the owner on Aug 31, 2022. It is now read-only.
make channel registry asynchronous#148
Open
AntoineDao wants to merge 1 commit into
Open
Conversation
We noticed that the Webhook sink was executing very slowly for high throughput events and concluded it was because the http requests were being executed synchronously. This commit fixes this by making the loop run in a go routine so it is not blocking.
Author
|
Bump for attention 😄 |
Contributor
|
Hello, this is a bit dangerous because in the event of a slow sink and high flow events, it might spawn unlimited go routines, eventually getting OOM-killed. Can you also make your test by making channel bufferred, so that writes to channel will not be blocking? |
Author
|
That makes sense. Should the channel buffer count be set in the config somehow so users can size their deployment as needed? |
Contributor
|
Would be better, but with a default value of say 10? But I also guess we still need goroutines and a proper wait group because the consumer/processor would still be one goroutine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that the Webhook sink was executing very slowly for high throughput events and concluded it was because the http requests were being executed synchronously. This commit fixes this by making the loop run in a go routine so it is not blocking.
I also added a quick test with a dummy slow sink.
Let me know if this change makes sense! 🙌