Issue 58 discovery #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
…t will be set to the fabric name in the configuration. The /sd now support the use of no query parameter target to return all configured fabric configurations.
Additional formatting of the targets format. Support discovery of all fabrics.
Merge from master
…ric + node, and for each aci fabric. This fix bug with faulty node response due to the connection was updated with the node name.
…emove spaces, tab and newline from the queries string.
…i_exporter_fabric" This will in future remove the need to add this default to all apic queries and add it at relabeling
…through the apic.The fabric name from the config file is now used as cache key prefix instead of the fabric domain name.
Service Discovery Crash Fix
…ated to a context was stored in the cached aciconnection
…iClient. This includes support for paging.
… one single is failing. the fix is to continue the loop and retrun the non failed, but if all fail, serviceDiscoveries is length 0, return 503
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.