-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make markdown root folder configurable #15
Conversation
1fc41b3
to
3260b27
Compare
@@ -39,6 +39,7 @@ | |||
"devDependencies": { | |||
"browserify": "^17.0.0", | |||
"decktape": "^3.14.0", | |||
"dotenv": "^16.4.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node should have a process
object to get envs from
process.env.PRESENTATIONS_ROOT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this the env should be exported. IMO, it would be better to read from .env
file directly rather than exporting the variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where will this setting be documented?
3260b27
to
c72f72b
Compare
I have updated the docs. 👍 |
c72f72b
to
de12ed9
Compare
de12ed9
to
0482540
Compare
Description
With this PR the markdown root folder can be made configurable. Previously all the presentation markdown files were supposed to be inside the markdown directory.
With the addition of new env
PRESENTATIONS_ROOT
, the root folder for all the presentation markdown files can be configured.Usage:
.env.example
and name it.env
PRESENTATIONS_ROOT=<markdown-directory-path>
The folder structure will be as below:
Added env on training repo as well: https://github.com/opf/training/pull/138
Related WP:
https://community.openproject.org/projects/revealjs/work_packages/60523/activity