Do not allow time tracking for users that are not visible to you #17793
+80
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaustopher
commented
Jan 31, 2025
Comment on lines
-120
to
-121
| def validate_logged_by_current_user | ||
| errors.add :logged_by_id, :not_current_user if model.logged_by != logged_by |
There was a problem hiding this comment.
this validation was never run, and logged_by is not even defined, so using it will throw a NoMethodError
oliverguenther
approved these changes
Jan 31, 2025
klaustopher
deleted the
bug/61084-when-allowed-to-log-time-entries-for-others
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/stream-time-and-costs/work_packages/61084
What are you trying to accomplish?
Prevent logging time for users that cannot be accessed by the user. This is currently only prevented by the auto completer, but not by the backend.
Screenshots
What approach did you choose and why?
Merge checklist