Better structure upcoming meetings by organising them into named date sections #17767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
commented
Jan 29, 2025
modules/meeting/app/models/queries/meetings/filters/time_filter.rb
Outdated
Show resolved
Hide resolved
oliverguenther
force-pushed
the
feature/meeting-index-organization
branch
7 times, most recently
from
d7e11fd to
7543612
Compare
oliverguenther
force-pushed
the
feature/meeting-index-organization
branch
3 times, most recently
from
a77ddc5 to
bfb30ad
Compare
mrmir
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Looks great!
I just have a minor comment about a comment, and want to ask if the last table should initially also show 20? I know the pagination should load 20 more each time, but I couldn't find anything in the spec about the initial count. Good to merge anyway, but maybe we should clarify this
oliverguenther
force-pushed
the
feature/meeting-index-organization
branch
2 times, most recently
from
cf31a0c to
bcd7d95
Compare
I reduced the initial count to 5, let's clarify today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/61030
Merge checklist