Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch relevant error during callback phase #14

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

NobodysNightmare
Copy link

I am not sure under which circumstances the original error condition yielding the CallbackError occurs. The newly added error occurs when we try to exchange the access token, but the client credentials are wrong. Thus I assume that we'd receive the same for all errors specified by the OAuth 2.0 spec.

Ticket

https://community.openproject.org/projects/openproject/work_packages/59960

I am not sure under which circumstances the original
error condition yielding the CallbackError occurs. The
newly added error occurs when we try to exchange the
access token, but the client credentials are wrong.
Thus I assume that we'd receive the same for all errors
specified by the OAuth 2.0 spec.
@NobodysNightmare NobodysNightmare requested a review from a team January 31, 2025 15:28
@NobodysNightmare NobodysNightmare merged commit 3d5fec6 into dev Feb 3, 2025
3 checks passed
@NobodysNightmare NobodysNightmare deleted the catch-errors branch February 3, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants