improve: blocklist of problematic resources for previous version annotation #2774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
csviri
changed the title
csviri
commented
Apr 28, 2025
...ramework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
xstefank
requested changes
Apr 29, 2025
| * | ||
| * @return blocklist of resource classes where the previous version annotation won't be used. | ||
| */ | ||
| default List<Class<? extends HasMetadata>> previousAnnotationUsageBlocklist() { |
There was a problem hiding this comment.
I would suggest also documenting the default implementation in the javadoc.
There was a problem hiding this comment.
Not sure that is needed / that helpful since users can just open the code and see the defaults, also we don't do it for other configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros [email protected]