Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List on Artifacthub: add initial artifacthub-repo.yml to claim repository ownership #182

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Aug 3, 2024

The Artifacthub package https://artifacthub.io/packages/helm/zipkin/zipkin refers to https://zipkin.io/zipkin-helm repository, adding the artifacthub-repo.yml over there so it could be discovered by Artifacthub (verified locally, http://localhost:4000/zipkin-helm/artifacthub-repo.yml is fully accessible)

Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for connecting the dots! Sorry it tripped lint 😊

@reta reta merged commit 3fa5079 into openzipkin:master Aug 4, 2024
1 check passed
@reta
Copy link
Contributor Author

reta commented Aug 4, 2024

@codefromthecrypt if you could hint me, the deployment should be in effect already (I believe) but https://zipkin.io/zipkin-helm/ is not being served properly (404). I made sure that bundle exec jekyll build serves the contend and github-pages build includes the content as well (under _site), do I miss something? thanks!

@codefromthecrypt
Copy link
Member

so this goes to the gh-pages branch of the zipkin-helm repo. You can see the direct content is served, so not sure what else we are looking for https://zipkin.io/zipkin-helm/index.yaml

If we want to serve under that subpath, it needs to be in zipkin-helm basically which maybe I misunderstood in approving the PR

@reta
Copy link
Contributor Author

reta commented Aug 5, 2024

If we want to serve under that subpath, it needs to be in zipkin-helm basically which maybe I misunderstood in approving the PR

Oh got it, thanks a lot @codefromthecrypt , I will retarget the change here, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants