refactor: singleton downloader #2190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
requested changes
Mar 19, 2025
There was a problem hiding this comment.
Sorry, but this is not what we want.
The goal of this issue about a singleton is to:
- have a single object, initialized once and for all, so that all calls have the same settings throughout the codebase ; here you've made all settings public and writable which means that we continue to have various behaviors ; maybe one or two settings must be tweakable at Downloader invocation, but then it means it is not a property of the object but a property of the invocation (function argument)
- stop passing downloader object in function invocation ; here you continue to pass the object instead of simply using the singleton in the function code (and importing this singleton in file obviously)
|
I apologize for the misunderstanding. I got it now. |
arjitcodes
force-pushed
the
refactor/downloader-singleton
branch
2 times, most recently
from
63e4df7 to
c14e1f1
Compare
benoit74
reviewed
Mar 24, 2025
There was a problem hiding this comment.
Some general remarks:
- please remove all commented code, this is not needed in the long run and makes the PR hard to read.
- I'm very embarassed by the use of
#fooprivate variable (in JS) ; while correct, it looks to me that most variable are declared withprivate foo(private TS variable) and having a mix of both semantic is kinda weird. And I'm really not sure we need the safety of JS private variables. Plus I find the use of a private JS variable + a public getter very verbose compared to simply having apublic readonly foo. Your views on this are welcomed.
benoit74
reviewed
Mar 24, 2025
|
@arjitcodes is this ready for a new review pass? |
|
Yes |
benoit74
force-pushed
the
refactor/downloader-singleton
branch
from
f92a0be to
cf7e4ee
Compare
|
Rebased on what is supposed to be a fixed CI. |
benoit74
requested changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2154
Implement a singleton pattern for the Downloader class.