Removed external dependency src/gutenberg2zim/templates/jquery/jquery… #238
Conversation
| @@ -29,7 +30,7 @@ def deps_already_installed(self) -> bool: | |||
| for dep in JS_DEPS: | |||
| if ( | |||
| not Path(self.root) | |||
| .joinpath("gutebergtozim/templates") | |||
There was a problem hiding this comment.
I'm a bit puzzled by this change, does it means we had a bug which forced dependencies to always be re-downloaded?
There was a problem hiding this comment.
No sir I actually wrote gutenbergtozim instead of gutenberg2zim. That's why.
There was a problem hiding this comment.
But why this change then, I don't get it, sorry
There was a problem hiding this comment.
I think there was a typo in the original code, it should be gutenberg2zim. I checked by running hatch build and it is working fine.
There was a problem hiding this comment.
I am sorry I changed it back to original and again it is working fine. I think we should stick to the original code. Should I make the changes?
There was a problem hiding this comment.
But why did you had to change this in the first place ? To me it looks like original code is wrong, but I would like to be sure about what we are doing.
There was a problem hiding this comment.
I changed it because after adding root directory, this code adds template which is under gutenberg2zim also the actual directory structure we observed when running ls -la src/ shows the directory name is gutenberg2zim. I have not changed it solve any bug I was going through the hatch_build.py file and thought this should be the correct line. But after you mentioned I changed it back to original and it is still working. I am also confused to be honest.
Issue #198
Removed the external dependency - jquery-1.11.1.min.js
On running
hatch buildthe dependency is getting downloaded to the repo