Userobj, groupobj and project quotas #727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah hmm it seems the |
"should be implenented" - is this ready for testing then or should it be implenented first before it gets to testing? |
The boolean featureflags in use thus far in ZFS are extremely useful, but because they take advantage of the zap layer, more interesting data than just a true/false value can be stored in a featureflag. In redacted send/receive, this is used to store the list of redaction snapshots for a redacted dataset. This change adds the ability for ZFS to store types other than a boolean in a featureflag. The only other implemented type is a uint64_t array. It also modifies the interfaces around dataset features to accomodate the new capabilities, and adds a few new functions to increase encapsulation. This functionality will be used by the Redacted Send/Receive feature. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Closes #7981
lundman
force-pushed
the
userobj_quota
branch
2 times, most recently
from
6a2a0c4 to
c488622
Compare
Change vnode ioctl to fcntl XNU will deny ioctl to any vnode that is not BLK or CHR. It is expected that fcntl() is used in this case. Change "zfs project" to use fcntl to query projid. Potentially there is no way to set project, without an equivalent tool to Linux "chattr". But pool import should at least work, as well as quota restrictions.
lundman
force-pushed
the
userobj_quota
branch
from
c23edcd to
c0f2977
Compare
|
I haven't tested much new functionality of this PR, I just use this branch with my ZFS pool created with current ZoL 0.8.4 without any features disabled by command from OpenZFS wiki on Debian root on ZFS : I saw two freezes today when I try to It contains only clone of opengapps repo in a subfolder and has mds disabled by file |
|
Oh sorry, not resets, but complete freezes, so GUI is there, but no clock ticks (I have seconds enabled in my clock). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the commit:
Add types to featureflags in zfsas well as commits for userobj quotas, and project quotas, all in one PR.
They are rather intertwined.
This is a port from HEAD on ZOL master today - not the original commits (plus updates). Some git history is lost.
Userobj, and Groupobj quotas appear to work:
Further testing of userobj, and groupobj quotas required.
Further testing with project quotas required.
zfs set|get project*quota | project*usedshould at least work.zfs projectcommand should run, but we expectInappropriate ioctl for deviceas there are no Projects in XNU.