unit/fletcher: test fletcher-2 and fletcher-4 checksums#18747
Open
chrislongros wants to merge 1 commit into
Open
unit/fletcher: test fletcher-2 and fletcher-4 checksums#18747chrislongros wants to merge 1 commit into
chrislongros wants to merge 1 commit into
Conversation
Cover known answers, incremental vs single-call agreement, varsize, byteswap, and cross-implementation equality. Signed-off-by: Christos Longros <chris.longros@gmail.com>
Contributor
Author
|
I am also considering a Monte Carlo test that tests bit flipping and random-sized increments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fletcher algorithm is the is checksum and hashing mechanism used in ZFS for error detection and data integrity.
Fletcher checksums have no test coverage. This adds a
test_fletchersuite that explicitly tests the Fletcher-2 and Fletcher-4 routines inzfs_fletcher.c, including every SIMD and scalar implementation the host supports.Description
Adds a
test_fletchersuite calling the Fletcher checksum functions:fletcher_4_native_varsize()vsfletcher_4_native(), native vs byteswap, and equality across every supported implementation (selected by name withfletcher_4_impl_set()).How Has This Been Tested?
make unit T=fletcher:Types of changes
Checklist: