[SDY] add sdy shard-group unification pass. This cl unifies shard group ids by "merging" groups which contain tensors that belong to more than one group across the module. Additionally it reindexes the sharding group ids to not have any gaps after merging. For example #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_658712042
branch
2 times, most recently
from
ce10268 to
976e9fc
Compare
copybara-service
bot
changed the title
…up ids by "merging" groups which contain tensors that belong to more than one group across the module. Additionally it reindexes the sharding group ids to not have any gaps after merging. For example
```
module {
func.func @test(%arg0: tensor<4xf32>, %arg1: tensor<4xf32>, %arg2: tensor<4xf32>) {
sdy.sharding_group %arg0 group_id = 12 : tensor<4xf32>
sdy.sharding_group %arg0 group_id = 25 : tensor<4xf32>
sdy.sharding_group %arg0 group_id = 39 : tensor<4xf32>
sdy.sharding_group %arg1 group_id = 39 : tensor<4xf32>
sdy.sharding_group %arg2 group_id = 44 : tensor<4xf32>
func.return
}
}
```
would **canonicalize** to
```
module {
func.func @test(%arg0: tensor<4xf32>, %arg1: tensor<4xf32>, %arg2: tensor<4xf32) {
sdy.sharding_group %arg0 group_id = 1 : tensor<4xf32>
sdy.sharding_group %arg0 group_id = 1 : tensor<4xf32>
sdy.sharding_group %arg0 group_id = 1 : tensor<4xf32>
sdy.sharding_group %arg1 group_id = 1 : tensor<4xf32>
sdy.sharding_group %arg2 group_id = 2 : tensor<4xf32>
func.return
}
}
```
since `%arg0` is in sharding groups {12,25,39} this implies all of these groups should be sharded similarly (and can share the same group id). `%arg2` doesn't cause any group_ids to merge but its group id is reindexed after the merging to be minimum.
PiperOrigin-RevId: 661475723
copybara-service
bot
force-pushed
the
test_658712042
branch
from
976e9fc to
88e11f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SDY] add sdy shard-group unification pass. This cl unifies shard group ids by "merging" groups which contain tensors that belong to more than one group across the module. Additionally it reindexes the sharding group ids to not have any gaps after merging. For example
would canonicalize to
since
%arg0is in sharding groups {12,25,39} this implies all of these groups should be sharded similarly (and can share the same group id).%arg2doesn't cause any group_ids to merge but its group id is reindexed after the merging to be minimum.