#sdy Add an event to the op priority schedule to propagate through all ops after element-wise ops, but **only** through non-passthrough factors. #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_726942878
branch
from
b551641 to
d9db3a7
Compare
copybara-service
bot
force-pushed
the
test_726942878
branch
from
d9db3a7 to
b398c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#sdy Add an event to the op priority schedule to propagate through all ops after element-wise ops, but only through non-passthrough factors.
In the test case added
pass_through_factor_higher_priority_than_reduction_factor, before we'd shard%arg0to[{?}, {"a", ?}]due to sideways propagation on the reduction factor. But now we halt that while we propagate through the non-contracting dim backwards from the result to get[{"a", ?}, {?}].