lxc: fix meson.build on esoteric host systems #28042
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building lxc's meson.build tries to infer something for the target system out of the host build OS. This isn't reproducible and can actually fail on some OS' like NixOS. The failure looked like this, early in the building stage of lxc: > ../../../../build_dir/target-aarch64_cortex-a53_musl/lxc-6.0.5/meson.build:166:8: ERROR: Problem encountered: "distrosysconfdir" is not set The /etc/default seems to be something that is derived on most host systems, so use that as the explicit config. This fixes building lxc on NixOS and similar. This also makes the build more pure and reproducible. Before this commit building the same set of checkouts, same config would yield different lxc artifacts on RedHat and Ubuntu. It was probably harmless though. Signed-off-by: Michal Kazior <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building lxc's meson.build tries to infer
something for the target system out of the host
build OS. This isn't reproducible and can actually fail on some OS' like NixOS.
The failure looked like this, early in the
building stage of lxc:
The /etc/default seems to be something that is
derived on most host systems, so use that as the
explicit config.
This fixes building lxc on NixOS and similar.
This also makes the build more pure and
reproducible. Before this commit building the same set of checkouts, same config would yield
different lxc artifacts on RedHat and Ubuntu.
It was probably harmless though.
📦 Package Details
Maintainer: @ratkaj
Description: LXC is the userspace control package for Linux Containers(...)
🧪 Run Testing Details
✅ Formalities