-
Notifications
You must be signed in to change notification settings - Fork 3.8k
snapcast: update to 0.34.0 #27728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
snapcast: update to 0.34.0 #27728
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,13 +3,13 @@ | |
| include $(TOPDIR)/rules.mk | ||
|
|
||
| PKG_NAME:=snapcast | ||
| PKG_VERSION:=0.28.0 | ||
| PKG_RELEASE:=2 | ||
| PKG_VERSION:=0.34.0 | ||
| PKG_RELEASE:=1 | ||
|
|
||
| PKG_SOURCE_PROTO:=git | ||
| PKG_SOURCE_URL:=https://github.com/badaix/snapcast.git | ||
| PKG_SOURCE_URL:=https://github.com/snapcast/snapcast.git | ||
| PKG_SOURCE_VERSION:=v$(PKG_VERSION) | ||
| PKG_MIRROR_HASH=288325fc8b134502adb522711c18210794734675684cf5d8eba8a0a82778f6c9 | ||
| PKG_MIRROR_HASH=b47c44e208708cbfd6fb89b5874ed05ffa165b959904ccc11b03073bf9b55b0a | ||
|
|
||
| PKG_MAINTAINER:=Szabolcs Hubai <[email protected]>, David Andreoletti <[email protected]> | ||
| PKG_LICENSE:=GPL-3.0-or-later | ||
|
|
@@ -19,16 +19,22 @@ PKG_CPE_ID:=cpe:/a:badaix:snapcast | |
| include $(INCLUDE_DIR)/package.mk | ||
| include $(INCLUDE_DIR)/cmake.mk | ||
|
|
||
| CMAKE_OPTIONS += -DBUILD_TESTS=OFF | ||
| CMAKE_OPTIONS += -DBUILD_WITH_PULSE=OFF | ||
| CMAKE_OPTIONS += -DBUILD_WITH_AVAHI=OFF | ||
| CMAKE_OPTIONS += \ | ||
| -DBUILD_TESTS=OFF \ | ||
| -DBUILD_WITH_ALSA=ON \ | ||
| -DBUILD_WITH_AVAHI=OFF \ | ||
| -DBUILD_WITH_JACK=OFF \ | ||
| -DBUILD_WITH_PIPEWIRE=OFF \ | ||
| -DBUILD_WITH_PULSE=OFF \ | ||
| -DBUILD_WITH_SSL=OFF \ | ||
| -DBUILD_WITH_TREMOR=ON | ||
|
|
||
| define Package/snapcast/Default | ||
| SECTION:=sound | ||
| CATEGORY:=Sound | ||
| TITLE:=Synchronous multiroom audio player | ||
| DEPENDS:=+AUDIO_SUPPORT:alsa-lib +libexpat +libatomic +libogg +libflac +libopus +boost +libsoxr | ||
| URL:=https://github.com/badaix/snapcast | ||
| DEPENDS:=+alsa-lib +libexpat +libatomic +libogg +libflac +libopus +boost +libsoxr | ||
| URL:=https://github.com/snapcast/snapcast | ||
| endef | ||
|
|
||
| define Package/snapcast/Default/description | ||
|
|
||
29 changes: 0 additions & 29 deletions
29
sound/snapcast/patches/001-v0.29.0-fix-compilation-with-boost-v1.87.0.patch
This file was deleted.
Oops, something went wrong.
87 changes: 0 additions & 87 deletions
87
...t/patches/002-v0.30.0-use-make_address-from-boost-as-from_string-is-deprecated-1308.patch
This file was deleted.
Oops, something went wrong.
44 changes: 0 additions & 44 deletions
44
sound/snapcast/patches/003-v0.30.0-fix-compilation-with-boost-v1.87.0.patch
This file was deleted.
Oops, something went wrong.
60 changes: 0 additions & 60 deletions
60
sound/snapcast/patches/004-v0.31.101-fix-compilation-with-boost-1.88.patch
This file was deleted.
Oops, something went wrong.
19 changes: 0 additions & 19 deletions
19
sound/snapcast/patches/005-v0.32.4-fix-building-with-boost-v1.89.0.patch
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xabolcs Out of curiosity, why is snapcast built with ALSA only and not also with the more modern tooling Pipewire/jack ?
Otherwise, the PR is good to go :-)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is Spartaaaaaaaaa! 😉
Those JACK and PipeWire backends are not implemented (packaged in OpenWrt) yet, and in the end OpenWrt is still an embedded distribution.
But as in the earlier PR I already wrote: I plan a minimal and a full flavour for these!
A slim with ALSA and a heavier with Pulse (and other) backend(s)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I was not the messenger ! LOL!
It makes sense now.