multi-arch-test-build: run it only after the Formality check succeeds #27592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
BKPepe
force-pushed
the
RunPackagesTestAfterFormality
branch
3 times, most recently
from
d599913 to
f1497d8
Compare
Member
|
I'm not sure if this is really necessary but LGTM |
BKPepe
force-pushed
the
RunPackagesTestAfterFormality
branch
from
f1497d8 to
3bc6658
Compare
Most of the time, when people contribute to the repository for the first time (or after a longer break), the multi-arch-test-build passes, but the formality check fails and requires the contributor to make some changes. This creates unnecessary load on the CI/CD, since the multi-arch-test-build runs again even though it already passed, while other PRs are waiting for a runner. Hopefully, this change will help decrease the waiting time. Proposed changes: - Run the formality check first, and only trigger the package tests afterwards. This can be done using needs: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idneeds - Merge formal.yml into multi-arch-test-build.yml so that needs can be used. Signed-off-by: Josef Schlehofer <[email protected]>
BKPepe
force-pushed
the
RunPackagesTestAfterFormality
branch
from
3bc6658 to
115e9c6
Compare
Member
Author
|
Okay, I pushed a small change. I shorten the name of the workflow, because there is also job's name. Also, improved the commit description a little bit. Thus this is ready. It does what it should. 😇 Well, I hope that this decrease the time while waiting for runner. Sometimes, it really takes ages. |
Member
|
The runners are taken by the core repository at the most of time, there're hundreds of tasks waiting to be checked. |
robimarko
approved these changes
Oct 5, 2025
GeorgeSapkin
approved these changes
Oct 5, 2025
Member
|
Indirectly, this “solves a problem” I encountered recently: once I chose to finish the code review before handling the formalities, after all the back and forth, the contributor did not want to use their real name. It’s a shame. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time, when people want to contribute to the repository for the first time or after a longer break, the multi-arch-test-build passes, but the formality check fails
and requires the user to make some changes.
This puts quite a load on the CI/CD, since the multi-arch-test-build runs again even though it already passed before.
Let’s now set it up so that the formality check is resolved first, and only then the package tests are executed.