Skip to content

Conversation

@BKPepe
Copy link
Member

@BKPepe BKPepe commented Oct 2, 2025

Maintainer: me

Description:
This PR adds:

  1. ivykis as library
  2. syslog-ng switch to CMake instead of autotools and add ivykis as dependency

🧪 Run Testing Details

So far so no, will be done later, compile tested

-------------------------------------------
syslog-ng Open Source Edition 4.10.0 configured
--------------- Environment ---------------
CMAKE_HOST_SYSTEM                   Darwin-25.0.0
CMAKE_HOST_SYSTEM_NAME              Darwin
CMAKE_HOST_SYSTEM_PROCESSOR         arm64
CMAKE_HOST_SYSTEM_VERSION           25.0.0
---------------- Compilers ----------------
CMAKE_C_COMPILER                    powerpc-openwrt-linux-musl-gcc[powerpc-openwrt-linux-musl-gcc (OpenWrt GCC 13.3.0 r28878+90-bb14c607a3) 13.3.0] - /Volumes/OpenWrt/turris1x-hbk/build/staging_dir/toolchain-powerpc_8548_gcc-13.3.0_musl/bin/powerpc-openwrt-linux-musl-gcc
CMAKE_CXX_COMPILER                  powerpc-openwrt-linux-musl-g++[powerpc-openwrt-linux-musl-g++ (OpenWrt GCC 13.3.0 r28878+90-bb14c607a3) 13.3.0] - /Volumes/OpenWrt/turris1x-hbk/build/staging_dir/toolchain-powerpc_8548_gcc-13.3.0_musl/bin/powerpc-openwrt-linux-musl-g++
--------------- Compilation ---------------
CMAKE_BUILD_TYPE                    Release
ENABLE_CPP                          Off
ENABLE_EXTRA_WARNINGS               On
ENABLE_FORCE_GNU99                  Off
ENV_LD_LIBRARY_PATH                 Off
----------------- Testing -----------------
BUILD_TESTING                       Off
---------------- Man pages ----------------
ENABLE_MANPAGES                     Off
ENABLE_MANPAGES_INSTALL             Auto (Off)
WITH_MANPAGES                       local
---------------- Features -----------------
ENABLE_ENV_WRAPPER                  Off
ENABLE_FORCED_SERVER_MODE           On
ENABLE_GCOV                         Off
ENABLE_GPROF                        Off
ENABLE_IPV6                         On
ENABLE_LINUX_CAPS                   Off
ENABLE_MEMTRACE                     Off
ENABLE_PERF                         Off
ENABLE_SPOOF_SOURCE                 Off
ENABLE_STACKDUMP                    Off
ENABLE_SYSTEMD                      Off
ENABLE_TCP_WRAPPER                  Off
SANITIZER                           Off
--------------- Sub-modules ---------------
IVYKIS_SOURCE                       system
----------------- Modules -----------------
ENABLE_AFAMQP                       Off
ENABLE_AFSMTP                       Off
ENABLE_AFSNMP                       Off
ENABLE_AFUSER                       On
ENABLE_AMQP                         Off
ENABLE_APPMODEL                     On
ENABLE_AZURE_AUTH_HEADER            On
ENABLE_CLOUD_AUTH                   Off
ENABLE_CURL                         On
ENABLE_EBPF                         Off
ENABLE_EXAMPLE_MODULES              Off
ENABLE_GEOIP2                       Off
ENABLE_GETENT                       On
ENABLE_GRPC                         Off
ENABLE_HOOK_COMMANDS                On
ENABLE_HTTP                         Off
ENABLE_JAVA                         Off
ENABLE_JAVA_MODULES                 Off
ENABLE_JOURNALD                     Off
ENABLE_JSON                         On
ENABLE_KAFKA                        Off
ENABLE_MAP_VALUE_PAIRS              On
ENABLE_MONGODB                      Off
ENABLE_MQTT                         Off
ENABLE_NATIVE                       On
ENABLE_OPENBSD_SYS_DRIVER           Off
ENABLE_PACCT                        On
ENABLE_PYTHON                       Off
ENABLE_PYTHON_MODULES               Off
ENABLE_REDIS                        Off
ENABLE_RIEMANN                      Off
ENABLE_SMTP                         Off
ENABLE_SQL                          On
ENABLE_STARDATE                     On
ENABLE_STOMP                        On
ENABLE_SUN_STREAMS                  Off
ENABLE_XML                          On
-------------------------------------------
  • OpenWrt Version:
  • OpenWrt Target/Subtarget:
  • OpenWrt Device:

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@BKPepe BKPepe requested a review from Copilot October 2, 2025 08:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds new ivykis library package and migrates syslog-ng build system from autotools to CMake while introducing ivykis as a dependency.

  • Introduces libs/ivykis package (headers, static and shared libs, pkgconfig file)
  • Replaces syslog-ng autotools configure flags with CMake options
  • Extends syslog-ng dependencies to include ivykis and adjusts install procedure

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
libs/ivykis/Makefile New package definition for ivykis (build, install, dev install)
admin/syslog-ng/Makefile Switch to CMake, add ivykis dependency, replace configure args with CMake options, adjust install cleanup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@BKPepe BKPepe force-pushed the CMake_syslog branch 5 times, most recently from 948d9e0 to 98efa11 Compare October 2, 2025 11:15
@BKPepe BKPepe requested a review from Copilot October 2, 2025 11:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@BKPepe BKPepe force-pushed the CMake_syslog branch 3 times, most recently from 6d66679 to 604ad67 Compare October 2, 2025 18:30
@BKPepe BKPepe marked this pull request as ready for review October 2, 2025 21:29
@BKPepe
Copy link
Member Author

BKPepe commented Oct 3, 2025

@neheb Could you take a look at it, please?

@BKPepe BKPepe force-pushed the CMake_syslog branch 5 times, most recently from 946afb0 to 1ced1bf Compare October 9, 2025 09:10
@BKPepe BKPepe requested a review from GeorgeSapkin October 9, 2025 09:56
Libivykis, an asynchronous I/O readiness notification library.
This library is required by syslog-ng and potentially other packages
that need event-driven I/O handling.

Signed-off-by: Josef Schlehofer <[email protected]>
- Using external ivykis package instead of internal build

- Disable optional modules (AMQP, Redis, MongoDB, etc.)

Signed-off-by: Josef Schlehofer <[email protected]>
@neheb
Copy link
Contributor

neheb commented Oct 17, 2025

Package syslog-ng is missing dependencies for the following libraries:
libcap.so.2

@BKPepe
Copy link
Member Author

BKPepe commented Oct 20, 2025

Thanks for testing, @neheb. I do have minimal build on my machine, thus that is why I have not experienced it. I will disable it. :)

@neheb
Copy link
Contributor

neheb commented Oct 21, 2025

btw there seems to be some whitespace. My editor did this:

@@ -124,7 +124,7 @@ define Package/syslog-ng/install

        $(INSTALL_DIR) $(1)/usr/lib
        $(CP) $(PKG_INSTALL_DIR)/usr/lib/*.so* $(1)/usr/lib/
-
+
        $(INSTALL_DIR) $(1)/usr/lib/syslog-ng
        $(CP) $(PKG_INSTALL_DIR)/usr/lib/syslog-ng/* $(1)/usr/lib/syslog-ng/

@GeorgeSapkin
Copy link
Member

Might as well update to 4.10.2.

@BKPepe
Copy link
Member Author

BKPepe commented Oct 21, 2025

Sure - #27684

@BKPepe
Copy link
Member Author

BKPepe commented Oct 28, 2025

At this point, it appears that syslog-ng requires dependencies even though it shouldn't, because the features that require them are disabled. Therefore, to prevent merging, I'm putting this on hold until this issue is resolved.

@BKPepe BKPepe added the blocked label Oct 28, 2025
@BKPepe BKPepe mentioned this pull request Oct 28, 2025
1 task
@BKPepe BKPepe changed the title syslog-ng: switch to CMake + add dependency ivykis for it syslog-ng: switch to CMake Oct 28, 2025
@BKPepe
Copy link
Member Author

BKPepe commented Oct 28, 2025

Ivykis dependency will be added in separate PR - #27717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants