-
Notifications
You must be signed in to change notification settings - Fork 3.8k
syslog-ng: switch to CMake #27590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
syslog-ng: switch to CMake #27590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds new ivykis library package and migrates syslog-ng build system from autotools to CMake while introducing ivykis as a dependency.
- Introduces libs/ivykis package (headers, static and shared libs, pkgconfig file)
- Replaces syslog-ng autotools configure flags with CMake options
- Extends syslog-ng dependencies to include ivykis and adjusts install procedure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| libs/ivykis/Makefile | New package definition for ivykis (build, install, dev install) |
| admin/syslog-ng/Makefile | Switch to CMake, add ivykis dependency, replace configure args with CMake options, adjust install cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
948d9e0 to
98efa11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6d66679 to
604ad67
Compare
|
@neheb Could you take a look at it, please? |
946afb0 to
1ced1bf
Compare
Libivykis, an asynchronous I/O readiness notification library. This library is required by syslog-ng and potentially other packages that need event-driven I/O handling. Signed-off-by: Josef Schlehofer <[email protected]>
- Using external ivykis package instead of internal build - Disable optional modules (AMQP, Redis, MongoDB, etc.) Signed-off-by: Josef Schlehofer <[email protected]>
|
|
Thanks for testing, @neheb. I do have minimal build on my machine, thus that is why I have not experienced it. I will disable it. :) |
|
btw there seems to be some whitespace. My editor did this: |
|
Might as well update to 4.10.2. |
|
Sure - #27684 |
|
At this point, it appears that syslog-ng requires dependencies even though it shouldn't, because the features that require them are disabled. Therefore, to prevent merging, I'm putting this on hold until this issue is resolved. |
|
Ivykis dependency will be added in separate PR - #27717 |
Maintainer: me
Description:
This PR adds:
🧪 Run Testing Details
So far so no, will be done later, compile tested
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.