Skip to content

Conversation

@BKPepe
Copy link
Member

@BKPepe BKPepe commented Sep 30, 2025

📦 Package Details

Maintainer: @fumiama
(You can find this by checking the history of the package Makefile.)

Description:
Release notes:
https://github.com/fumiama/base16384/releases/tag/v2.3.2


✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@BKPepe
Copy link
Member Author

BKPepe commented Oct 1, 2025

The failing test is really interesting.

Use package specific test.sh
/ci/utils/base16384/test.sh: line 5: opkg: not found
/ci/utils/base16384/test.sh: line 8: base64: not found

@fumiama
Copy link
Contributor

fumiama commented Oct 1, 2025

Wow, it is quite weird because only version is changed. In the new version, I only changed CMakeLists.txt, so maybe some changes in this repo caused this problem.

@wehagy
Copy link
Member

wehagy commented Oct 2, 2025

The test.sh script is using opkg, but now we are using apk in the snapshot and probably in the next stable release. It's strange that the test is successful anyway, maybe it's because of the exit 0?

I have this migration on my radar, as some documentation and scripts are using opkg only.

@BKPepe
Copy link
Member Author

BKPepe commented Oct 6, 2025

Related to #27607

@hnyman hnyman merged commit 4e41b92 into openwrt:master Oct 11, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants