Skip to content

Conversation

@BKPepe
Copy link
Member

@BKPepe BKPepe commented Sep 30, 2025

📦 Package Details

Maintainer: @bk138
(You can find this by checking the history of the package Makefile.)

Description:
Release announcement:
https://lists.gnu.org/archive/html/info-gnu/2025-04/msg00007.html


🧪 Run Testing Details

  • OpenWrt Version: 24.10
  • OpenWrt Target/Subtarget: powerpc8540/mpc85xx
  • OpenWrt Device: Turris 1.1

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@bk138
Copy link
Contributor

bk138 commented Oct 1, 2025

CI errors shall be fixed, of course.

Add TARGET_CFLAGS += -std=gnu17
to fix following error discovered by CI/CD:
2025-09-30T23:53:47.3168066Z In file included from gzip.c:66:
2025-09-30T23:53:47.3189341Z gzip.c:131:34: error: expected declaration specifiers or '...' before numeric constant
2025-09-30T23:53:47.3190258Z   131 | # define BUFFER_ALIGNED alignas (4096)
2025-09-30T23:53:47.3190760Z       |                                  ^~~~
2025-09-30T23:53:47.3191259Z gzip.h:108:39: note: in definition of macro 'DECLARE'
2025-09-30T23:53:47.3191864Z   108 | #  define DECLARE(type, array, size)  type array[size]
2025-09-30T23:53:47.3192411Z       |                                       ^~~~
2025-09-30T23:53:47.3192942Z gzip.c:135:13: note: in expansion of macro 'BUFFER_ALIGNED'
2025-09-30T23:53:47.3193587Z   135 | DECLARE(uch BUFFER_ALIGNED, inbuf,  INBUFSIZ +INBUF_EXTRA);
2025-09-30T23:53:47.3194137Z       |             ^~~~~~~~~~~~~~
2025-09-30T23:53:47.3194752Z gzip.c:131:34: error: expected declaration specifiers or '...' before numeric constant
2025-09-30T23:53:47.3195442Z   131 | # define BUFFER_ALIGNED alignas (4096)
2025-09-30T23:53:47.3195880Z       |                                  ^~~~
2025-09-30T23:53:47.3196330Z gzip.h:108:39: note: in definition of macro 'DECLARE'
2025-09-30T23:53:47.3197297Z   108 | #  define DECLARE(type, array, size)  type array[size]
2025-09-30T23:53:47.3197829Z       |                                       ^~~~
2025-09-30T23:53:47.3198342Z gzip.c:136:13: note: in expansion of macro 'BUFFER_ALIGNED'
2025-09-30T23:53:47.3199113Z   136 | DECLARE(uch BUFFER_ALIGNED, outbuf, OUTBUFSIZ+OUTBUF_EXTRA);
2025-09-30T23:53:47.3199957Z       |             ^~~~~~~~~~~~~~
2025-09-30T23:53:47.3200589Z gzip.c:131:34: error: expected declaration specifiers or '...' before numeric constant
2025-09-30T23:53:47.3201250Z   131 | # define BUFFER_ALIGNED alignas (4096)
2025-09-30T23:53:47.3201688Z       |                                  ^~~~
2025-09-30T23:53:47.3202128Z gzip.h:108:39: note: in definition of macro 'DECLARE'
2025-09-30T23:53:47.3202665Z   108 | #  define DECLARE(type, array, size)  type array[size]
2025-09-30T23:53:47.3203150Z       |                                       ^~~~
2025-09-30T23:53:47.3203642Z gzip.c:138:13: note: in expansion of macro 'BUFFER_ALIGNED'
2025-09-30T23:53:47.3204203Z   138 | DECLARE(uch BUFFER_ALIGNED, window, 2L*WSIZE);
2025-09-30T23:53:47.3204684Z       |             ^~~~~~~~~~~~~~

- Release announcement:
https://lists.gnu.org/archive/html/info-gnu/2025-04/msg00007.html

Signed-off-by: Josef Schlehofer <[email protected]>
@BKPepe
Copy link
Member Author

BKPepe commented Oct 1, 2025

Yeah, interesting enough, I am not able to reproduce it against OpenWrt 24.10, it just works fine.

@bk138
Copy link
Contributor

bk138 commented Oct 1, 2025

Lgtm

@hnyman hnyman merged commit 3bf64e3 into openwrt:master Oct 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants