Skip to content

Conversation

@systemcrash
Copy link
Contributor

Gate all parameters behind -n, a not-empty check.

Closes #27430

📦 Package Details

Maintainer: @
(You can find this by checking the history of the package Makefile.)

Description:


🧪 Run Testing Details

  • OpenWrt Version:
  • OpenWrt Target/Subtarget:
  • OpenWrt Device:

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@systemcrash systemcrash changed the title clamav: freshclam; init; add only non-empty parameters clamav: all; init; add only non-empty parameters Sep 30, 2025
@wehagy
Copy link
Member

wehagy commented Oct 2, 2025

Need to bump PKG_RELEASE.

@systemcrash
Copy link
Contributor Author

done

Gate all parameters behind -n, a not-empty check. Prevents failed starts
where daemons expect a value for a parameter.

Closes openwrt#27430
Tested-on: 24.10.3
Signed-off-by: Paul Donald <[email protected]>
@wehagy
Copy link
Member

wehagy commented Oct 2, 2025

Unrelated CI error, maybe related to #27478 (comment):

   ERROR: package/feeds/packages_ci/rust [host] failed to build.
Building bootstrap
error: failed to calculate checksum of: /builder/build_dir/target-x86_64_musl/host/rustc-1.90.0-src/vendor/serde-1.0.215/Cargo.toml.orig

Caused by:
  failed to open file `/builder/build_dir/target-x86_64_musl/host/rustc-1.90.0-src/vendor/serde-1.0.215/Cargo.toml.orig`

Caused by:
  No such file or directory (os error 2)
failed to run: /builder/build_dir/target-x86_64_musl/host/rustc-1.90.0-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /builder/build_dir/target-x86_64_musl/host/rustc-1.90.0-src/src/bootstrap/Cargo.toml -Zroot-dir=/builder/build_dir/target-x86_64_musl/host/rustc-1.90.0-src
Build completed unsuccessfully in 0:00:16
make[2]: *** [Makefile:108: /builder/build_dir/target-x86_64_musl/host/rustc-1.90.0-src/.built] Error 1
make[2]: Leaving directory '/feed/lang/rust'
time: package/feeds/packages_ci/rust/host-compile#37.37#24.46#60.37

Merging, thanks.

@wehagy wehagy merged commit 4c35b89 into openwrt:master Oct 2, 2025
11 of 12 checks passed
@systemcrash systemcrash deleted the freshclam_fix branch October 18, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clamav/freshclam: clamav daemon fails due to freshclam config error (and wrong path, too)

2 participants