-
Notifications
You must be signed in to change notification settings - Fork 3.8k
lzbench: Add new package #27569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lzbench: Add new package #27569
Conversation
|
Please add a commit description with a reason for introducing this package or at least its description. |
ab5cee7 to
2224caa
Compare
Done |
lzbench is an in-memory benchmark for open-source compression algorithms. It integrates multiple compression libraries into a single executable. Allows for easy comparison of compression speed, decompression speed, and compression ratio. Useful for tweaking nginx/squashfs/etc compression and as CPU benchmarking tool. Signed-off-by: Nikita Solianik <[email protected]>
2224caa to
e97940a
Compare
BKPepe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have briefly reviewed this package and have some feedback. However, I will not be using lzbench on the router, and it is uncertain whether others will find it useful. Therefore, I suggest leaving the decision to merge this package into the repository to someone else.
| $(MAKE_FLAGS) | ||
| endef | ||
|
|
||
| TARGET_CFLAGS := $(filter-out -O%,$(TARGET_CFLAGS)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this does not make any sense as we are adding cflags below.
| TARGET_CFLAGS := $(filter-out -O%,$(TARGET_CFLAGS)) |
I am thinking that we can drop this.
| define Build/Compile | ||
| $(MAKE) -C $(PKG_BUILD_DIR) \ | ||
| $(MAKE_FLAGS) | ||
| endef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have our own Build/Compile section? Can not we use the default one?
Default one is:
define Build/Compile/Default
+$(MAKE_VARS) \
$(MAKE) $(PKG_JOBS) -C $(PKG_BUILD_DIR)/$(MAKE_PATH) \
$(MAKE_FLAGS) \
$(1);
endef
I dropped this and it works.
| define Build/Compile | |
| $(MAKE) -C $(PKG_BUILD_DIR) \ | |
| $(MAKE_FLAGS) | |
| endef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new package called lzbench to the OpenWrt package collection. lzbench is an in-memory benchmark tool for comparing open-source compression algorithms, integrating multiple compression libraries into a single executable for easy performance comparison.
Key changes:
- New package definition with proper metadata and dependencies
- Custom build configuration that disables most optional compression libraries to minimize dependencies
- Standard OpenWrt package structure with install rules
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| $(MAKE) -C $(PKG_BUILD_DIR) \ | ||
| $(MAKE_FLAGS) | ||
| endef | ||
|
|
Copilot
AI
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TARGET_CFLAGS optimization level filtering is placed after the Build/Compile definition but before MAKE_FLAGS. This ordering could be confusing. Consider moving this line to be grouped with the MAKE_FLAGS definition or add a comment explaining why optimization flags are being removed.
| # Remove optimization flags from TARGET_CFLAGS to avoid overriding package-specific optimization settings |
|
I highly doubt that pre-compiling the compression test bench binaries for all our architectures is worthwhile. |
📦 Package Details
Maintainer: @gxcreator
Description:
lzbench is an in-memory benchmark for open-source compression algorithms. It integrates multiple compression libraries into a single executable and allows for easy comparison of compression speed, decompression speed, and compression ratio.
https://github.com/inikep/lzbench.git
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.