Skip to content

Conversation

@Ra2-IFV
Copy link
Contributor

@Ra2-IFV Ra2-IFV commented Sep 30, 2025

📦 Package Details

Maintainer: @Ansuel @neheb
(You can find this by checking the history of the package Makefile.)

Description:
Fixing good


🧪 Run Testing Details

I swear I tested the binary. As for the init script not yet. I'm burning out.

  • OpenWrt Version: 16416782f194d1850a9d9accf02f04832a7fcea4
  • OpenWrt Target/Subtarget: aarch64
  • OpenWrt Device: aarch64 generic

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@Ra2-IFV Ra2-IFV changed the title umurmur: Bump to 0.3.1 umurmur: Bump to 0.3.1, improve init script Sep 30, 2025
@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Sep 30, 2025

Tue Sep 30 15:22:14 2025 daemon.info uMurmurd[4979]: uMurmur version 0.3.0 ('Loopy') protocol version 1.2.4
Tue Sep 30 15:22:14 2025 daemon.info uMurmurd[4979]: Visit https://github.com/umurmur/umurmur
Tue Sep 30 15:22:18 2025 daemon.warn uMurmurd[4979]: SSL: verify error:num=18:self-signed certificate:depth=0:/CN=Mumble User
Tue Sep 30 15:22:18 2025 daemon.info uMurmurd[4979]: User provided admin password - [1] REDACTED
Tue Sep 30 15:22:18 2025 daemon.info uMurmurd[4979]: User REDACTED authenticated - [1] REDACTED
Tue Sep 30 15:22:18 2025 daemon.info uMurmurd[4979]: New UDP connection from REDACTED on port 61142 - [1] REDACTED

@BKPepe
Copy link
Member

BKPepe commented Sep 30, 2025

Why have you created PR for updating umurmur, when already there is one?
#27562

$(INSTALL_DIR) $(1)/etc/config
$(INSTALL_CONF) $(CURDIR)/files/umurmur.conf $(1)/etc/config/umurmur
$(INSTALL_DIR) $(1)/etc/umurmur
$(INSTALL_CONF) $(PKG_BUILD_DIR)/umurmur.conf.example $(1)/etc/umurmur/umurmur.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are shipping two files?

This has the same structure as the config file, which you are adding.

No, we dont really need two config files, this leads to misunderstandings, because you dont know, which one should use and copy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is for uci, that saves some critical things, like host, port and config location. Why hardcoding the config location? just let procd & uci do these things, plz....
Another one is for mumble.
pkgname.conf and pkgname.init is common practice, isnt it? Do you have a better idea?
I think it's okay on user side, add comments in Makefile? It's not shipped to end user.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comments in the Makefile? These are not necessary at all.

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll delete them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I mean the 1-4 lines on the top, okay to delete, or keeping them?

@BKPepe
Copy link
Member

BKPepe commented Sep 30, 2025

Love story does not belong to the commit description:

I spent 3 hours fixing the variable simply because
I didn't read fking full build log.
So poor I am. I can never be a good developer nor maintainer.  ;(

🤷

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Sep 30, 2025

Love story does not belong to the commit description:

I spent 3 hours fixing the variable simply because
I didn't read fking full build log.
So poor I am. I can never be a good developer nor maintainer.  ;(

🤷

Yeah, I know, just want someone to hear me crying loudly, in front of a computer but it's not running JavaScript.
Thank you for checking my commit messages! Am I doing better than before on this?

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Sep 30, 2025

Why have you created PR for updating umurmur, when already there is one? #27562

When I was struggling boxing with errors, I didn't know that you have an existing pr. sry.

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Sep 30, 2025

@BKPepe And your solution is absolutely better. I simply removed *_LIBRARIES because we have *_LIB_PATH and *_INCLUDE_PATH, it should't point to a directory, and I don't know what does this do, so just removed.
Thanks teacher, another brilliant lesson!

@Ra2-IFV Ra2-IFV force-pushed the feat_umurmur_bump branch 2 times, most recently from 1a9ab0e to b7f51e2 Compare September 30, 2025 20:36
@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Sep 30, 2025

Great! Both binary and init script passed test in my case. I still can't have a bundled apk file tho

OpenWrt ~ # service umurmur info
{
        "umurmur": {
                "instances": {
                        "instance1": {
                                "running": true,
                                "pid": 9594,
                                "command": [
                                        "/usr/sbin/umurmurd",
                                        "-d",
                                        "-c",
                                        "/etc/umurmur/umurmur.conf",
                                        "-a",
                                        "0.0.0.0",
                                        "-A",
                                        "::",
                                        "-b",
                                        "64738",
                                        "-B",
                                        "64738"
                                ],
                                "term_timeout": 5
                        }
                },
                "triggers": [

                ]
        }
}

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Sep 30, 2025

Test formalities failed because: umurmur!: ......
Because this is a breaking change, default conf location changed.
Is it possible to have a post-install script to migrate conf file?

Ra2-IFV added a commit to Ra2-IFV/umurmur that referenced this pull request Sep 30, 2025
Move these files to OpenWrt repo.
For pending pull request, see link below.

Link: openwrt/packages#27566

Signed-off-by: Ryan Keane <[email protected]>
troxor pushed a commit to umurmur/umurmur that referenced this pull request Sep 30, 2025
Move these files to OpenWrt repo.
For pending pull request, see link below.

Link: openwrt/packages#27566

Signed-off-by: Ryan Keane <[email protected]>
@wehagy wehagy changed the title umurmur: Bump to 0.3.1, improve init script umurmur: improve init script Oct 2, 2025
@wehagy
Copy link
Member

wehagy commented Oct 2, 2025

Is it possible to have a post-install script to migrate conf file?

The correct way to do this is to use UCI defaults. Search the repository for *.defaults to see some examples.

Test formalities failed because: umurmur!: ......
Because this is a breaking change, default conf location changed.

The formalities check is correct. Please read the CONTRIBUTING.md and Submission Guidelines:

  • Have a useful commit subject prefixed with the package name.
  • Don't capitalize first word after the prefix.

@BKPepe
Copy link
Member

BKPepe commented Oct 2, 2025

Yeah, I know, just want someone to hear me crying loudly, in front of a computer but it's not running JavaScript.

You could use PR description for it, but not commit itself as it stays in the history forever, but yeah, mistakes happens.
Sometimes, it is better to take a time, summarize what you want to say as currently this simple PR has almost 30 comments and that's not good. Hards to follow it, etc.

@Ra2-IFV Ra2-IFV force-pushed the feat_umurmur_bump branch from b7f51e2 to cff830d Compare October 7, 2025 11:44
@Ra2-IFV Ra2-IFV requested a review from BKPepe October 7, 2025 14:02
Copy link
Member

@BKPepe BKPepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through your proposed changes, but unfortunately some of them don’t quite make sense and I don’t see much value in them. I’d recommend reviewing how init scripts and UCI config files are written and what they’re meant to do — the OpenWrt documentation explains it well. If you’re still uncertain, you can always ask tools like ChatGPT, Claude AI, or GitHub Copilot for help. There’s absolutely nothing wrong with using them — just remember to double-check their suggestions.

Comment on lines 1 to 2
option umurmur 'config'
option conffile '/etc/umurmur/umurmur.conf'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why conffile? Does it need to be conffile?

What about option config_path or config_file as it it common in other uci config files in this repository?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm stubborn, I think checking random words from AI is so tiring and can't learn anything
I grown up by googling, reading mans and wikis, and viewing others codes. Sometimes (Usually, actually?) I'm careless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark conversation resolved by yourself? I'm too afraid to mark it resolved by myself now, just to make sure that everything is reviewed by you

Comment on lines 3 to 6
option address4 '0.0.0.0'
option address6 '::'
option port4 '64738'
option port6 '64738'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this just for IP protocol and port does it make sense to introduce such breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a breaking change I guess, by default it listens to that address and port

COMMAND      PID            USER FD   TYPE DEVICE SIZE/OFF NODE NAME
umurmurd  200752         umurmur  3u  IPv4 307954      0t0  TCP *:64738 (LISTEN)
umurmurd  200752         umurmur  4u  IPv6 307955      0t0  TCP *:64738 (LISTEN)
umurmurd  200752         umurmur  5u  IPv4 307956      0t0  UDP *:64738
umurmurd  200752         umurmur  6u  IPv6 307957      0t0  UDP *:64738

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reworked — the intent was misunderstood. Right now you’re adding UCI and init options to allow separate IPv4/IPv6 addresses and different ports for each IP. In practice, separate ports are rarely used and will complicate client and admin setups. On typical Linux systems a single port bound on a dual-stack address (e.g. ::) will handle both IPv6 and IPv4 (unless the system explicitly enforces IPv6-only sockets), so a single port option is the norm.

Adding separate ports options changes the configuration schema and defaults, which risks a breaking change for existing deployments. Please revert the separate-port fields and expose only a single port plus a bind_address option (default :: or 0.0.0.0), and keep the new options optional so existing UCI configs continue to work. Also ensure the init script runs the daemon in the foreground under procd (no -d/daemonize).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package doesn't use UCI before, shouldn't breaking existing things.
Removing separate ports option makes sense, but I suggest keeping both 0.0.0.0 and :: as I explained before.
You misunderstood the -d flag, it makes it run in foreground, default behavior is fork to background.

Comment on lines +1 to +2
#!/bin/sh /etc/rc.common
# Copyright (C) 2006-2008 OpenWrt.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you take this copyright and how are you affilated to it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From upsteam? You can check here
Not sure what to do with this line if I overhauled the whole file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please look at CONTRIBUTING.md at this repository or Contributing guidelines, which are available at OpenWrt wiki.

Comment on lines +32 to +21
procd_set_param stdout 1
procd_set_param stderr 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to really have enabled stdout and stderr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, I give -d in CLI, it does print logs

# bash -xc 'umurmurd -d &2>/dev/null '
+ umurmurd -d
# INFO: OpenSSL library initialized (version: OpenSSL 3.5.3 16 Sep 2025)
INFO: Setting default channel 'Lobby'
INFO: Adding channel 'Lobby' parent 'Root'
INFO: Adding channel 'Silent' parent 'Root'
INFO: Adding channel 'Chatroom' parent 'Root'
INFO: No channel links found in configuration file.
FATAL: bind 0.0.0.0 64738: Address in use

@@ -0,0 +1,6 @@
option umurmur 'config'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this UCI config, I miss options like:

  • enabled
  • user:group
  • password for Mumble server, if someone wants to have it private

BTW: I think AI such as ChatGPT, Copilot might help you with this one instead of reinveinting a wheel here

Copy link
Contributor Author

@Ra2-IFV Ra2-IFV Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run user & group, password cannot be specified in CLI, but in conf file
Is this that necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I basically learn everything from wiki and @1715173329 .
Some pages on wiki is outdated, I registered an account for editing but no contributions so far.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run user & group
Is this that necessary?

It’s not absolutely necessary for functionality, but it’s strongly recommended for security reasons. Running the daemon under root means any potential vulnerability could lead to full system compromise. By specifying a dedicated user and group in the UCI config, the service can drop privileges after startup and run in a restricted context. This is standard practice for most network services in OpenWrt and Linux in general.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, done. Most packages doesn't do this though

Comment on lines 5 to 6
option port4 '64738'
option port6 '64738'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to specify port for IPv4 and IPv6? That seems really weird for me.
That is not even in umurmur/umurmur@209edb5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it can listen on different ports for IPv4 & 6.
If you only specify port for one IP protocol, another doesn't follow that.

umurmurd  200844         umurmur  3u  IPv4 315714      0t0  TCP *:64738 (LISTEN)
umurmurd  200844         umurmur  4u  IPv6 315715      0t0  TCP *:64739 (LISTEN)
umurmurd  200844         umurmur  5u  IPv4 315716      0t0  UDP *:64738
umurmurd  200844         umurmur  6u  IPv6 315717      0t0  UDP *:64739

Comment on lines -92 to +93
-DMBEDTLS_LIBRARIES="$(STAGING_DIR)/usr/lib" \
-DMBEDTLS_LIBRARIES="$(STAGING_DIR)/usr/lib/libmbedtls.so" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done in separate commit, but I am not sure what are you fixing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what build error have you experienced? I dont see that it fails on buildbots.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't be an error because MbedTLS_INCLUDE_DIRS is correct, but this variable is wrong indeed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other libraries such as mbedcrypto, mbedx509? 🤔

Comment on lines 21 to 27
config_get address4 "config" "address4" '0.0.0.0'
config_get address6 "config" "address6" '::'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but what are you trying to do it here?

Why don't e.g. do bind_address as ::It would listen on IPv4 and IPv6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But sadly that flag needs a valid address, can't be empty
Or I have to write more if lines in script, worth or not?

@@ -0,0 +1,4 @@
if [ -f '/etc/umurmur.conf' ]; then
[ -f '/etc/umurmur/umurmur.conf' ] && mv /etc/umurmur/umurmur.conf{,.apk-new}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, is it okay to rename to apk-new?

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Oct 7, 2025

@BKPepe 57 comments... I'll try not being that lazy next time....
@wehagy When do uci-default scripts run, precisely? Wiki says

Scripts in /etc/uci-defaults will get executed at every first boot (i.e. after a clean install or an upgrade)

A fresh package install and existing package upgrade?

@BKPepe
Copy link
Member

BKPepe commented Oct 8, 2025

I'll try not being that lazy next time....

I explored a possible alternative using AI, which might serve as a cleaner skeleton for future improvements. It’s just an idea that could make the configuration easier to work with.

Config:

config umurmur 'main'
	option enable '1'                    
	option user 'umurmur'
	option group 'umurmur'
	option port '64738'                  
	option bind_address '0.0.0.0'       
	option max_users '100'
	option welcometext 'Welcome'
	option password ''                   
	option ssl_cert '/etc/umurmur/umurmur.crt'
	option ssl_key '/etc/umurmur/umurmur.key'
	option logfile '/var/log/umurmur.log'
	option loglevel 'info'             
	option banfile '/etc/umurmur/bans.txt'
	option channels '/etc/umurmur/channels.conf'

Init:

#!/bin/sh /etc/rc.common
# Init script for uMurmur (Mumble server)
# OpenWrt style - supports UCI config

START=95
STOP=10
USE_PROCD=1
PROG=/usr/sbin/umurmurd

start_service() {
	config_load umurmur
	config_get_bool enabled main enable 0
	[ "$enabled" -eq 1 ] || {
		echo "uMurmur disabled in UCI config"
		return 1
	}

	config_get user main user 'umurmur'
	config_get group main group 'umurmur'
	config_get port main port '64738'
	config_get bind main bind_address '0.0.0.0'
	config_get max_users main max_users '100'
	config_get welcometext main welcometext 'Welcome to uMurmur!'
	config_get password main password ''
	config_get ssl_cert main ssl_cert '/etc/umurmur/umurmur.crt'
	config_get ssl_key main ssl_key '/etc/umurmur/umurmur.key'
	config_get logfile main logfile '/var/log/umurmur.log'
	config_get loglevel main loglevel 'info'
	config_get banfile main banfile '/etc/umurmur/bans.txt'
	config_get channels main channels '/etc/umurmur/channels.conf'

	
	cat <<-EOF > /var/etc/umurmur.conf
	# Auto-generated by /etc/init.d/umurmur
	port = $port
	bindaddr = $bind
	max_users = $max_users
	password = $password
	welcometext = "$welcometext"
	ssl_cert = $ssl_cert
	ssl_key = $ssl_key
	logfile = $logfile
	loglevel = $loglevel
	banfile = $banfile
	channels = $channels
	EOF

	procd_open_instance
	procd_set_param command $PROG -c /var/etc/umurmur.conf
	procd_set_param user "$user"
	procd_set_param respawn
	procd_close_instance
}

stop_service() {
	procd_kill umurmur
}	

**That said, it’s worth checking whether all these options actually exist and work as expected — this needs proper testing. As I mentioned, AI can be both a good and a bad helper. There’s no need to reinvent the wheel if a solid solution already exists.

Please take a look and see if this approach really makes sense.**

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Oct 8, 2025

Please take a look and see if this approach really makes sense.**

I know this approach, but is it okay to violate the configuration file?
I mean, is it really okay to integrate config with uci so deeply? It makes the whole thing more complicated, and, before, uci config is only for critical things, and the left for config file. It's that simple.
This approach let users take care of 3 files, uci, ban file and channel file. And if umurmur introduces more features (more configurable things) in the future it will be even more complicated!
I see run user run group can be set via procd, I'll take that

@BKPepe
Copy link
Member

BKPepe commented Oct 10, 2025

I mean, is it really okay to integrate config with uci so deeply? It makes the whole thing more complicated, and, before, uci config is only for critical things, and the left for config file. It's that simple.

Well, why not? Why yes? I mean, if you’d like to have UCI config, then you’d probably want LUCI integration as well, right? 😇

Here is the screenshot how it could look from AI:
ChatGPT Image 10  10  2025 09_10_18

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Oct 10, 2025

I'm not planning to add luci support, because I don't touch luci related things...
I still suggest keeping it simple, at least, not in this commit, let's make it work first, plz

@BKPepe
Copy link
Member

BKPepe commented Oct 10, 2025 via email

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Oct 10, 2025

Well, maybe, I have to learn them from scratch and may take a long time, and if so this will be my first try
for now just some minor improvements

Fix CMake MBEDTLS_LIBRARIES variable.
It should set to a list of files, instead of directories.

Signed-off-by: Ryan Keane <[email protected]>
@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Oct 12, 2025

No more amending required on this PR, I guess, LuCI support is on the way, uci config support is the base :)

Copy link
Member

@BKPepe BKPepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this is ready to be merged at this point. And honestly, asking for it to be merged just to have your first contribution checked off your to-do list isn’t the right approach — that’s not how it works, unfortunately.

You mentioned that you plan to create a simple UCI configuration file and mark it as a conffile. That’s fine in principle — it ensures the file won’t be overwritten when new updates are installed. Instead, users or administrators who install the package would be responsible for reviewing and applying any config changes themselves (e.g. through the -opkg or -apk suffix).

That said, maybe I’m being a bit strict here, but we simply can’t add a UCI config that offers only two options and isn’t fully thought through. This is a small change, but one that could introduce breaking changes just for the sake of having something merged — especially if you don’t actively use umurmur yourself.

umurmur is actually a great package to learn from: it’s simple enough, but it still needs to be properly implemented and covered from all angles.

Right now, it would be better to make this more solid — for example, by preparing a LuCI integration later on.
But first, you should start with an init script, then gradually add the UCI config and adjust the init script accordingly. Or, if needed, spend more time on self-study and prepare it properly so that it’s truly ready for merging.

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Oct 21, 2025

Roger, sir. But I want to finish this PR asap so I'll stage uci config related changes in another branch for uses ( luci )

Breaking change: Config file location now defaults to:
/etc/umurmur/umurmur.conf
And with uci-defaults script to migrate.

Init script is now in "files" directory, instead of from upstrem.
uMurmur example config file is now from upstream example file.
Init script now calls procd to monitor service state.

Signed-off-by: Ryan Keane <[email protected]>
STOP=01
USE_PROCD=1

CONF="umurmurd"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used where?


start_service() {
local user group
user=umurmur group=umurmur
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is not defined in the config file?

@BKPepe
Copy link
Member

BKPepe commented Oct 30, 2025

I need to close this as this is not ready to be merged. Because you removed init file and config file from umurmur (umurmur/umurmur@209edb5), we can not fix the init script in the released version (there is a bug with moved binary) and we need to ship our own init script file, which I will do.

@BKPepe BKPepe closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants