Skip to content

Conversation

@oowl
Copy link

@oowl oowl commented Sep 30, 2025

Add a check for status existence before processing.

In my OpenWRT device, it did not have a Wi-Fi device, so if I use prometheus-node-exporter-lua, I found below error in my syslog.
image

📦 Package Details

Maintainer: @
(You can find this by checking the history of the package Makefile.)

Description:


🧪 Run Testing Details

  • OpenWrt Version:
  • OpenWrt Target/Subtarget:
  • OpenWrt Device:

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@oowl oowl changed the title fix: check if status is nil before processing interfaces in prometheu… fix: check if status is nil before processing interfaces in prometheus-node-exporter-lua Sep 30, 2025
@oowl oowl changed the title fix: check if status is nil before processing interfaces in prometheus-node-exporter-lua fix: check if status is nil before processing wifi device metrics interfaces in prometheus-node-exporter-lua Sep 30, 2025
@BKPepe BKPepe requested a review from champtar October 1, 2025 17:35
@systemcrash
Copy link
Contributor

@oowl properly name your commit subject after squashing the two commits.

@oowl
Copy link
Author

oowl commented Oct 2, 2025

@systemcrash Done, Sir. PTAL

@champtar champtar changed the title fix: check if status is nil before processing wifi device metrics interfaces in prometheus-node-exporter-lua prometheus-node-exporter-lua: check if status is nil before processing wifi device metrics interfaces Oct 10, 2025
@champtar
Copy link
Member

@oowl I've edited the PR title, please edit your commit title to start with prometheus-node-exporter-lua

@oowl
Copy link
Author

oowl commented Oct 11, 2025

@champtar done

@systemcrash
Copy link
Contributor

I thought you already did it but please fix your commit SOB.

@oowl
Copy link
Author

oowl commented Oct 16, 2025

@systemcrash Sorry, I did not understand your requirement. I have been squashing my commits into one commit and also changed my PR title with proper words.

I thought you already did it but please fix your commit SOB.

SOB seems offensive words? mean Son of Bitch?

@systemcrash
Copy link
Contributor

Copilot AI review requested due to automatic review settings December 4, 2025 04:27

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants