-
Notifications
You must be signed in to change notification settings - Fork 3.8k
ddns-scripts: fixed ovh dns record update #27561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddns-scripts: fixed ovh dns record update #27561
Conversation
0e9aac2 to
ed94a2c
Compare
ed94a2c to
19ef850
Compare
|
@kolacinskikarol In the past, you were doing some changes for OVH ddns-script. Would you mind to take a look at it, please? |
836874e to
289d433
Compare
|
@kolacinskikarol @BKPepe This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the OVH DNS record update functionality by adapting to OVH's API changes that now require HTTP Basic Authorization. The solution involves moving the DNS update logic from a simple URL-based approach to a dedicated script that properly handles authentication.
- Updated ovh.com.json configuration to use a custom update script instead of direct URL calls
- Created update_ovh_com.sh script that implements proper HTTP Basic Authorization for OVH's API
- Added new ddns-scripts-ovh package to handle OVH-specific DNS updates
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| net/ddns-scripts/files/usr/share/ddns/default/ovh.com.json | Updated to reference custom update script instead of direct API URLs |
| net/ddns-scripts/files/usr/lib/ddns/update_ovh_com.sh | New script implementing OVH DynHost API with HTTP Basic Authorization |
| net/ddns-scripts/Makefile | Added new ddns-scripts-ovh package definition and build configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a08158f to
fcfdd67
Compare
|
Please bump PKG_RELEASE in the make file. The other things LGTM. |
fcfdd67 to
4bc9d9c
Compare
done. |
OVH changed its API to update DNS records. It now requires HTTP Basic Authorization header. As such the default ddns-script method to update the DNS record is failing. The fix is to move DNS record updates into its own script/package. Signed-off-by: David Andreoletti <[email protected]>
4bc9d9c to
73266f8
Compare
|
Thanks merged! |
📦 Package Details
Maintainer: @feckert
Description:
Fixes #27526.
OVH changed its API to update DNS records. It now requires HTTP Basic Authorization header. As such the default ddns-script method to update the DNS record is failing. The fix is to move DNS record updates into its own script/package.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
No patch.