syslog-ng: add ivykis dependency to fix building with enabled KERNEL_IO_URING #27551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BKPepe
force-pushed
the
syslog-ng_add_iiburing
branch
from
2c14eff to
cd5537a
Compare
Member
Author
Member
Author
|
It looks I'll need to prepare build env for aarch64 to take a look at it further. Unfortunately, this was not discovered by GitHub Actions when updating it - #26785. At least OpenWrt buildbots discovered it. |
BKPepe
force-pushed
the
syslog-ng_add_iiburing
branch
from
cd5537a to
36df81c
Compare
|
@BKPepe: Good job on it :) |
Contributor
|
Well, for what it is worth... I upgraded to 24.10.4 with The build failure is with the build bots... the package itself does not need this PR, at least on aarch64, and at least on a Mediatek device. |
BKPepe
force-pushed
the
syslog-ng_add_iiburing
branch
from
b923dea to
761016b
Compare
Member
Author
|
This depends on #27717 |
BKPepe
changed the title
Replace embedded ivykis with a separate package to improve dependency management and enable library reuse. The ivykis library now properly supports io_uring when CONFIG_KERNEL_IO_URING is enabled. Signed-off-by: Josef Schlehofer <[email protected]>
BKPepe
force-pushed
the
syslog-ng_add_iiburing
branch
from
761016b to
839ec70
Compare
Member
Author
|
Backported to OpenWrt 24.10 - 607aa2a |
BKPepe
added a commit
to BKPepe/turris-build
that referenced
this pull request
Oct 30, 2025
This patch was added to fix something, but the solution is different [1]. This is just a workaround, which works, but the newly added dependency ivykis will be required when I will switch syslog-ng to use cMake instead of autotools. [1] openwrt/packages#27551 Signed-off-by: Josef Schlehofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile and run tested: NO
Currently don't have aarch64 env.
On OpenWrt buildbots, I noticed that syslog-ng fails for aarch64 and x86_64, because these two targets has enabled KERNEL_IO_URING [1] and syslog-ng detects it, wants to use it and thus it fails on buildbots:
[1] https://github.com/openwrt/openwrt/blob/0147d213ffaf52a444bf0dd0c2ccd9b929ef448c/config/Config-kernel.in#L571
Buildbots failure:
OpenWrt 24.10: https://downloads.openwrt.org/releases/faillogs-24.10/aarch64_cortex-a53/packages/syslog-ng/compile.txt
OpenWrt snapshot: https://downloads.openwrt.org/snapshots/faillogs/aarch64_cortex-a53/packages/syslog-ng/compile.txt