prometheus-node-exporter-lua remove zero values

[NoctivagusObitus]

depending on the configuration there may be multiple interfaces creating multiple time series always
reporting 0 value. omiting them from the export saves resources. most notably cpu.

• remove time series with value of zero
• make 'omit_zero_values' configurable
• formating accoding to shfmt and stylua

Signed-off-by: Markus Hube [email protected]

[NoctivagusObitus]

@champtar may I kindly ask if you could have a look at this? I would be happy to change the pull request given you have concerns.

[rwrnet]

@champtar has this any chance to be merged? Like to have this option too.

[NoctivagusObitus]

@1715173329 do you think we may get this merged? I would be happy to rework the pr as offered here if so desired.

[1715173329]

I'm neither the maintainer of this package nor familiar with it, sorry for that.
But at least, please bump PKG_RELEASE, and split your commits. One commit for adding omit_zero_values option, and another for style fixes.

@champtar kindly ping

[NoctivagusObitus]

Sure. I am aware that your are not the maintainer and that you will not do the review or merge. Still thank you for your fast response.

I have split the changes into two commits and implemented the "only counter" logic.

[NoctivagusObitus]

any chance on progressing on this?

[NoctivagusObitus]

@1715173329 sorry for bothering you again. might there by any chance of progressing without waiting for @champtar to respond?

[1715173329]

Please rebase this PR to resolve conflicts, otherwise LGTM.

[NoctivagusObitus]

Thanks a lot. since there have been some changes in place I touched I would like to rebase and let it run on my devices for a bit to make sure I did not mess up anything. I will get back to you.

[NoctivagusObitus]

@1715173329 I have been running my fixed version now for a few weeks and it is looking good in my opinion.

for clarity. the CPU reduction is less significant these days since we are using buffered writes in lua by now. still it seams quite reasonable to avoid generating data which is not needed.

[1715173329]

Merged, thank you!

[champtar]

Sorry for never responding on this one, I was not super convinced as this is not something present in the go version, but it's disabled by default so that's fine
Thanks @NoctivagusObitus and @1715173329

[NoctivagusObitus]

thank you @champtar for your acknowledgement, thank you @1715173329 for the merge. I am happy to have this feature opt in and happy to see it upstream :)