luci-theme-bootstrap: disable Dark Reader #8115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable Dark Deader since the bootstap theme has built-in dark and light modes, as well as a mode which auto-detects the user's preference. Dark Reader also doesn't work well with the bootstrap theme. Signed-off-by: Mikael Magnusson <[email protected]>
Contributor
|
Is darkreader the browser's own built in reader mode? |
Contributor
Author
|
It's a browser extension. I added a link in the PR. |
Contributor
|
On the one hand we carry a 'stop' for a proprietary browser extension, on the other, it's trivial. |
Contributor
|
Merged. Thanks @mikma |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to disable Dark Deader browser extension in the bootstap theme since the theme has built-in dark and light modes, as well as a mode which auto-detects the user's preference. Dark Reader also doesn't work well with the bootstrap theme, as seen below when using Dark Reader:
Before the change in this PR:
After the change in this PR:
