Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 support #317

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

ulgens
Copy link
Contributor

@ulgens ulgens commented Nov 8, 2024

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #314 .

Description of Changes

  • Removes the majority of the compatibility code for <3.9 versions of Python
  • Remove 3.8 from CI and docs
  • Modernize the code for Python 3.9 with the help of pyupgrade.

@ulgens
Copy link
Contributor Author

ulgens commented Nov 8, 2024

One thing I couldn't find enough time to handle is GeoJsonDict. There is

remove this when support for python 2.6/2.7 will be dropped

note in the dosctring, but it's not clear what it refers to. It's been a while since 2.6/2.7 got EOL, and it looks like the class has multiple relatively complex usages in the codebase. I can use some help.

@ulgens ulgens marked this pull request as draft November 8, 2024 09:13
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulgens thx 🙏.
The build is failing due to a QA check, an unused import.

@ulgens
Copy link
Contributor Author

ulgens commented Nov 9, 2024

@nemesifier Should be okay now

@ulgens
Copy link
Contributor Author

ulgens commented Nov 9, 2024

It fails because of the commit messages now. I feel like the QA is a bit strict, not sure how much value is provided by having [action] prefix on every commit but I can update them if needed.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails because of the commit messages now. I feel like the QA is a bit strict, not sure how much value is provided by having [action] prefix on every commit but I can update them if needed.

It helps the change log, but don't worry too much about it if you can't get it, we can sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Drop Python 3.8 support
2 participants