[change] Move python dependencies to requirements.txt file #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified pip.yml to install dependencies from requirements.txt - Used role_path variable to reference requirements.txt in files directory - Implemented pip constraints to maintain version control from Ansible variables - Kept an extra_python_packages handling for custom additions - and preserved existing retry logic and environment settings
- Here grouped dependencies by their functionality (core, database, optional) - Added few comments to indicate optional packages and their purpose - While maintaining existing version constraints for critical packages - I've ensured compatibility with current OpenWISP installation process
- Added pip package ecosystem to dependabot configuration - While setting up weekly update schedule for dependency checks - Added all 'dependencies' and 'python' labels for better PR organization
nemesifier
requested changes
Jan 31, 2025
.github/dependabot.yml
Outdated
| interval: "monthly" # Check for updates weekly | ||
| commit-message: | ||
| prefix: "[ci] " | ||
| prefix: "deps" |
There was a problem hiding this comment.
Suggested change
| prefix: "deps" | |
| prefix: "[deps]" |
| commit-message: | ||
| prefix: "[deps] " | ||
| - package-ecosystem: "github-actions" # Check for GitHub Actions updates |
There was a problem hiding this comment.
Why are you removing github-actions? Please don't.
There was a problem hiding this comment.
I've made the fix for this in my recent commit
- Maintained consistent prefix formatting using square brackets: [deps] for pip and [ci] for GitHub Actions - Restored the GitHub Actions ecosystem configuration - Setup both update intervals to "weekly" as originally intended
nemesifier
requested changes
Feb 4, 2025
There was a problem hiding this comment.
@shwetd19 the build is failing. Please execute the tests locally before pushing.
|
Hey @nemesifier , The main issue was that the requirements.txt file cannot be found during the installation process. The error message was consistent across different Ubuntu and Debian environments I've made the possible fix and did tested it properly this time can you please review my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #507
Description of Changes
This PR here implements automated dependency management using Dependabot by extracting Python dependencies from
pip.ymlinto a dedicatedrequirements.txtfile.Key Changes:
New Requirements File
files/requirements.txtcontaining all Python dependenciesUpdated Package Installation
tasks/pip.ymlto use the new requirements fileDependabot Configuration
Testing Details:
Installation Testing
Tested with various configurations:
Integration Testing
Benefits:
Screenshots