Add achievement items that modify reduced scoring. #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
changed the title
somiaj
force-pushed
the
reduced-cred-achievement-items
branch
4 times, most recently
from
16c28d2 to
892d7f7
Compare
somiaj
force-pushed
the
reduced-cred-achievement-items
branch
from
892d7f7 to
f751675
Compare
somiaj
force-pushed
the
reduced-cred-achievement-items
branch
from
f751675 to
b8af387
Compare
somiaj
force-pushed
the
reduced-cred-achievement-items
branch
from
b8af387 to
13eebc0
Compare
somiaj
force-pushed
the
reduced-cred-achievement-items
branch
from
13eebc0 to
47dff20
Compare
somiaj
force-pushed
the
reduced-cred-achievement-items
branch
2 times, most recently
from
590f4dd to
4bdf826
Compare
somiaj
force-pushed
the
reduced-cred-achievement-items
branch
from
4bdf826 to
9111ee8
Compare
|
Updated with the suggestions from the meeting. I now correctly don't let the extension to go beyond the due date, and don't list sets whose due date and reduced scoring date are the same. I also added a statement about the reduced scoring date cannot be extended beyond the due date in the items description. |
|
I'm working on modifying how achievement items are used, and it would be nice if this PR and the other one modifying AchievementItems were merged before I get to far into the updates, since all AchievementItems will need updated. |
This adds achievement items that modify the reduced scoring time period while leaving other settings alone. These are designed for classes which use reduced scoring and keep assignments open in the reduced scoring period for a long time (such as the end of the course). + ExtendReducedDate -> Extends the reduced scoring date 24 hours. + SuperExtendReducedDate -> Extends the reduced scoring date 48 hours. + NoReducedCred -> Removes the reduced scoring flag on an assignment to allow full credit after the reduced scoring date.
somiaj
force-pushed
the
reduced-cred-achievement-items
branch
from
9111ee8 to
a04aad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds achievement items that modify the reduced scoring time period while leaving other settings alone. These are designed for classes which use reduced scoring and keep assignments open in the reduced scoring period for a long time (such as the end of the course).
In short these provide extensions for a reduced scoring setup.