Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triangle and quadrilateral tools to the graph tool. #1191

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

drgrice1
Copy link
Member

@drgrice1 drgrice1 commented Feb 8, 2025

These were requested by Robin Cruz in https://webwork.maa.org/moodle/mod/forum/discuss.php?d=8646.

The usage of the new tools is documented in the parserGraphTool.pl macro.

Example problems for testing this are attached.

Quadrilateral.pg.txt
Triangle.pg.txt

@drgrice1 drgrice1 force-pushed the graphtool-triangle-and-quadrilateral branch 9 times, most recently from f17313d to d88fb39 Compare February 11, 2025 12:09
@pstaabp
Copy link
Member

pstaabp commented Feb 11, 2025

The triangle tool worked well.

When I used your sample problem with many different seeds (248, 6775), the correct answer wasn't accepted. Those both had internal crossings, so I thought that might be an issue, but I even hardcoded a simple square and didn't work.

These were requested by Robin Cruz in
https://webwork.maa.org/moodle/mod/forum/discuss.php?d=8646.

The usage of the new tools is documented in the parserGraphTool.pl
macro.
@drgrice1 drgrice1 force-pushed the graphtool-triangle-and-quadrilateral branch from d88fb39 to 0d76db2 Compare February 11, 2025 13:22
@drgrice1
Copy link
Member Author

There was a mistake that I fixed recently that made it so the quadrilateral cmp method wasn't even being called. It should work now.

Copy link
Member

@pstaabp pstaabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works now. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants