Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing of object, map, and array literals #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jggatter
Copy link

No description provided.

2 11
MIXED
a 1
b 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you decided that you wanted to assert that there would be a newline added here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the newline in that WDL command so that Cromwell output would match this output file. If you're referring to lack of new line at the end of file, I don't know what's right, I just wanted write_map() to give a similar format to array's write_lines()

@@ -0,0 +1,3 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this if the file is empty?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FileNotFoundError: Could not find any of test_data.json,tests/test_data.json starting from /Users/jggatter/Desktop/Projects/Testathon-2020/pytest-wdl-tests/tests/whitespace

I deleted the jsons and the input dictionaries from every line in the python script and it gave me that error message. Any way around supplying inputs to py-test wdl?


workflow mixed {
input {
String message = "I am a document. I am mixed. Let me fail!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? This looks fine to me?

If I'm reading this right: The engine will strip the common spacing from the start of the command section, and then the python heredoc will have a single tab indentation in it?

Copy link
Author

@jggatter jggatter Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed to read task definition at line 17 column 6 (reason 1 of 1): Cannot mix leading whitespace characters in command: [" ", "\t"]

I get this error message, I believe it fails because of the tab in the heredoc
I did also try a version where I put a tab on line 6 or 7 and that failed similarly

Copy link
Contributor

@cjllanwarne cjllanwarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you please add docker images for all of your tasks?

@jggatter jggatter requested a review from cjllanwarne February 20, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants