fix: didRotate signature in DID Exchange Response #2241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: Ariel Gentile <[email protected]>
genaris
force-pushed
the
fix/v0.5.x-did-peer-4-did-exchange-request
branch
from
fcbd0ad to
c23872d
Compare
TimoGlastra
approved these changes
Apr 3, 2025
TimoGlastra
merged commit 5e2e66a
into
openwallet-foundation:v0.5.x
9 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting a fix done in #2166 (and the following fix in #2229) to 0.5.x branch.
It touches only resolvable did use cases (did:peer:4 and public dids), leaving intact the typical did:peer:1 cases (if it works, don't touch it!).
For the moment I'm testing it with success in 0.5.13 agents, using did:peer:4 by default in DID Exchange requests.