fix: blank v2 proof request notification #1400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Due to the change in functionality from V1 to V2, the body (usually the name field of the proof request) was missing for all v2 proofs. This change checks to see if a standard presentation object exists in v2 proofs and returns the name field if present. As with v1, it falls back to the comment, if no name is present. I added a comment highlighting the Credo API used and simplified the logic a bit, removing some unnecessary duplication.
Additionally I included some EOFs that myself and other developers were seeing as diffs every time we installed and built the project.
Screenshots, videos, or gifs
This is a screenshot of a proof request notification from VCAuthn, a service the BC Gov provides that uses the V2 protocol - as you can see the name is present
Breaking change guide
N/A
Related Issues
bcgov/bc-wallet-mobile#2125
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓