Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blank v2 proof request notification #1400

Merged

Conversation

bryce-mcmath
Copy link
Contributor

@bryce-mcmath bryce-mcmath commented Jan 17, 2025

Summary of Changes

Due to the change in functionality from V1 to V2, the body (usually the name field of the proof request) was missing for all v2 proofs. This change checks to see if a standard presentation object exists in v2 proofs and returns the name field if present. As with v1, it falls back to the comment, if no name is present. I added a comment highlighting the Credo API used and simplified the logic a bit, removing some unnecessary duplication.

Additionally I included some EOFs that myself and other developers were seeing as diffs every time we installed and built the project.

Screenshots, videos, or gifs

This is a screenshot of a proof request notification from VCAuthn, a service the BC Gov provides that uses the V2 protocol - as you can see the name is present
notification_v2_proof_name

Breaking change guide

N/A

Related Issues

bcgov/bc-wallet-mobile#2125

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@bryce-mcmath bryce-mcmath requested a review from a team as a code owner January 17, 2025 00:48
@al-rosenthal al-rosenthal merged commit a94474e into openwallet-foundation:main Jan 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants