-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to disable pin explainer screen #1343
feat: add flag to disable pin explainer screen #1343
Conversation
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review linting configuration and make sure the project's linting rules are being applied
Signed-off-by: fc-santos <[email protected]>
@cvarjao The prettier configuration is being applied from the .prettierrc file as you can see in the output below: ["INFO" - 13:37:36] Using ignore file (if present) at /Projet/aries-mobile-agent-react-native/.prettierignore
["INFO" - 13:37:36] File Info:
{
"ignored": false,
"inferredParser": "typescript"
}
["INFO" - 13:37:36] Detected local configuration (i.e. .prettierrc or .editorconfig), VS Code configuration will not be used
["INFO" - 13:37:36] Prettier Options:
{
"filepath": "/Projet/aries-mobile-agent-react-native/packages/legacy/core/App/screens/PINCreate.tsx",
"parser": "typescript",
"endOfLine": "lf",
"printWidth": 120,
"semi": false,
"singleQuote": true
}
["INFO" - 13:37:36] Formatting completed in 33ms. The way prettier works is if you don't define some options, like traillingComma, there is a default. In this case the default is all, which adds the comma at the end of an object. |
Signed-off-by: fc-santos <[email protected]>
Quality Gate passedIssues Measures |
Summary of Changes
This PR adds a flag so a wallet can disable the PINExplainer screen. By the default, the PINExplainer Screen is enabled.
Screenshots, videos, or gifs
N/A
Breaking change guide
N/A
Related Issues
This PR also address the following issue #1328
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓