Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keypoint detection export with explain #4192

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Update keypoint detection export with explain #4192

merged 3 commits into from
Jan 30, 2025

Conversation

sovrasov
Copy link
Contributor

Summary

  • Export with explain now doesn't fail on a kp det model, even though it's not supported. A warning is shown instead
  • Revert OV model template changes, as our primary model is multi-object one, single object is to be removed.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sovrasov sovrasov merged commit 3c949c5 into openvinotoolkit:releases/2.3.0 Jan 30, 2025
26 of 27 checks passed
ashwinvaidya17 pushed a commit to ashwinvaidya17/training_extensions that referenced this pull request Feb 7, 2025
@sovrasov @ashwinvaidya17
Update keypoint detection export with explain (openvinotoolkit#4192)
3db97d1 
* Revert "Fix KP Export (single obj case) (openvinotoolkit#4191)"

This reverts commit 35fdb7f.

* Update aouto configuration to support kp format

* Relax KP explain export checks
ashwinvaidya17 pushed a commit to ashwinvaidya17/training_extensions that referenced this pull request Feb 7, 2025
@sovrasov @ashwinvaidya17
Update keypoint detection export with explain (openvinotoolkit#4192)
db5878f 
* Revert "Fix KP Export (single obj case) (openvinotoolkit#4191)"

This reverts commit 35fdb7f.

* Update aouto configuration to support kp format

* Relax KP explain export checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene123tw eugene123tw eugene123tw approved these changes

@negvet negvet negvet approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@kprokofi kprokofi Awaiting requested review from kprokofi kprokofi is a code owner

@Daankrol Daankrol Awaiting requested review from Daankrol Daankrol is a code owner

@djdameln djdameln Awaiting requested review from djdameln djdameln is a code owner

@ashwinvaidya17 ashwinvaidya17 Awaiting requested review from ashwinvaidya17 ashwinvaidya17 is a code owner

@rajeshgangireddy rajeshgangireddy Awaiting requested review from rajeshgangireddy rajeshgangireddy is a code owner

@atwinand atwinand Awaiting requested review from atwinand atwinand is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sovrasov @eugene123tw @negvet