Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KP task to work in Geti scenario #4189

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

kprokofi
Copy link
Collaborator

Summary

How to test

  1. Only keypoint annotations are available in arrow file in Geti.
  2. We need to use different set of augmentations to work as expected without Bboxes (==different config).

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (releases/2.3.0@0c624a4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/otx/core/data/dataset/keypoint_detection.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             releases/2.3.0    #4189   +/-   ##
=================================================
  Coverage                  ?   79.56%           
=================================================
  Files                     ?      324           
  Lines                     ?    32713           
  Branches                  ?        0           
=================================================
  Hits                      ?    26027           
  Misses                    ?     6686           
  Partials                  ?        0           
Flag Coverage Δ
py310 79.49% <50.00%> (?)
py311 79.53% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kprokofi
Copy link
Collaborator Author

I confirm that now the training is working (it trains, it outputs some metric) with Geti config and provided to me arrow file

@sovrasov
Copy link
Contributor

I confirm that now the training is working (it trains, it outputs some metric) with Geti config and provided to me arrow file

If the arrow being used is compact enough, we might need it later for the integration tests

@kprokofi
Copy link
Collaborator Author

We have again CI problem with IS task, can we avoid it for this PR? I didn't touch anything related to IS. We need to prioritize merging this PR

@sovrasov sovrasov merged commit 40b82f6 into releases/2.3.0 Jan 28, 2025
24 of 25 checks passed
@sovrasov sovrasov deleted the kp/fix_kp_geti_task branch January 28, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants