[NPU] Add compatibility checks before compiling model with compiler in plugin #24502
Conversation
| @@ -163,6 +163,11 @@ bool NPUBackends::isBatchingSupported() const { | |||
| return false; | |||
| } | |||
|
|
|||
| bool NPUBackends::isCompilerFallbackRequired() const { | |||
| static const uint32_t lastCompatibleVersion = 2196; | |||
There was a problem hiding this comment.
Will this require manual maintenance?
There was a problem hiding this comment.
I think this method will be updated and, in the end removed in the future. This check is added in order to prevent CID fallback for some drivers (that don't have graph extension 1.6) that could use CIP instead. However, CIP is continuously being developed and I don't expect for the compatibility between older drivers and CIP to persist. When the last driver that doesn't contain graph extension 1.6 will be 'not supported' by CIP, we will be able to remove this check altogether.
There was a problem hiding this comment.
Does it work for both linux and windows drivers?
There was a problem hiding this comment.
I've updated this check to work for both
| uint32_t patch; | ||
|
|
||
| inline bool isCompatible(const Version& other) const { | ||
| return this->major == other.major && this->minor == other.minor; // TODO: needs confirmation |
There was a problem hiding this comment.
Just a reminder to remove this comment upon receiving the confirmation. Perhaps we should do this prior to merging the PR.
There was a problem hiding this comment.
What kind of confirmation do we need here? If we still need such a confirmation after merging the PR, could we open a ticket and remove this comment?
There was a problem hiding this comment.
We should be able to support backward compatibility by this check. So we need to support cases when driver minor version >= compiler minor version
There was a problem hiding this comment.
updated the check and moved it inside plugin.cpp
There was a problem hiding this comment.
Sorry, I do not see the check inside plugin.cpp
I see that we checked that versions are not nullpts and then adding them into config. Am I missing something?
|
@ArtemySkrebkov @pereanub @PatrikStepan Could you please have a look? |
| uint32_t patch; | ||
|
|
||
| inline bool isCompatible(const Version& other) const { | ||
| return this->major == other.major && this->minor == other.minor; // TODO: needs confirmation |
There was a problem hiding this comment.
What kind of confirmation do we need here? If we still need such a confirmation after merging the PR, could we open a ticket and remove this comment?
Details:
Tickets: