Fix/smooth quant param grid #3694
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed a subtle bug in _get_smooth_quant_param_grid where matmul values were returned as single-element tuples instead of plain floats.
Replaced:
AdvancedSmoothQuantParameters(matmul=alpha_v) for alpha_v in itertools.product(alpha_values)
With:
AdvancedSmoothQuantParameters(matmul=alpha_v) for alpha_v, in itertools.product(alpha_values)
This ensures matmul values are floats, preventing TypeError in the PTQ pipeline.
Reason for changes
itertools.product always returns tuples, even for a single iterable.
Previously, this caused a crash when the code tried to compare sq_params.matmul >= 0 because tuples cannot be compared to integers.
The change fixes this by unpacking the single-element tuples to get plain float values.
Related tickets
Closes #3613
Tests
Verified manually that _get_smooth_quant_param_grid() now returns AdvancedSmoothQuantParameters with float matmul values, e.g., 0.15, 0.25, instead of (0.15,).
Results of test :
0.15 <class 'float'>
0.25 <class 'float'>
0.5 <class 'float'>
...
Ran existing pytest suite — all tests passed successfully.
No new tests were required as the logic is unchanged, only the tuple unpacking was fixed.