Skip to content

BUILD: Resolve absolute prefix in cmake config. - #1314

Open
chuckatkins wants to merge 1 commit into
openucx:masterfrom
chuckatkins:cmake-absolute-paths
Open

BUILD: Resolve absolute prefix in cmake config.#1314
chuckatkins wants to merge 1 commit into
openucx:masterfrom
chuckatkins:cmake-absolute-paths

Conversation

@chuckatkins

@chuckatkins chuckatkins commented May 14, 2026

Copy link
Copy Markdown

What

Resolve the install prefix to an absolute path in the imported CMake config.

Why ?

Current imported CMake targets contain deeply nested relative paths, i.e. /path/to/install/lib/cmake/ucc/../../../lib/libucx.so. Resolving to an absolute path in the imported config gives a much cleaner path for the build system, i.e. /path/to/install/lib/libucc.so while still keeping the config portable by leaving the prefix derivation from ${CMAKE_CURENT_LIST_DIR} unchanged.

This is also consistent with ucx-targets.cmake

@chuckatkins
chuckatkins marked this pull request as ready for review May 14, 2026 17:40
@janjust
janjust force-pushed the cmake-absolute-paths branch from 6e6a578 to 9ac7fae Compare June 3, 2026 17:16
@janjust

janjust commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

/build

@janjust
janjust self-requested a review June 3, 2026 17:16
@chuckatkins
chuckatkins force-pushed the cmake-absolute-paths branch from 9ac7fae to 5f127dc Compare June 25, 2026 17:54
@chuckatkins chuckatkins changed the title BUILD: Resolve install prefix to an absolute path in cmake config. BUILD: Resolve absolute prefix in cmake config. Jun 25, 2026
@chuckatkins

Copy link
Copy Markdown
Author

Only changed the PR title and commit message to fit the len < 50 check

@janjust

janjust commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

/build

@dpressle

Copy link
Copy Markdown
Collaborator

@ci-triage-agent

@dpressle

Copy link
Copy Markdown
Collaborator

👀 Investigating interactive

@dpressle

Copy link
Copy Markdown
Collaborator

🤖 CI Triage Agentinteractive · commit 5f127dc2

The logs are clear. I have a definitive root cause without needing any further investigation.


Summary: Codestyle CI check failed because the commit title ends with a trailing period (.), which is forbidden by the project's commit message linting rules.

Root cause: The commit 5f127dc2 on PR #1314 has the title "BUILD: Resolve absolute prefix in cmake config." — note the trailing .. The codestyle job enforces a check_title() rule that explicitly rejects any commit title whose last character is a .:

if [ "${msg: -1}" = "." ]
then
  echo "Dot at the end of title"
  return 1
fi

The CI script found exactly that and printed:

Dot at the end of title
Bad commit title: 'BUILD: Resolve absolute prefix in cmake config.'
Process completed with exit code 1.

Implicated commit: [REDACTED:Hex High Entropy String] (HEAD of PR #1314"BUILD: Resolve absolute prefix in cmake config.")

File: .github/workflows/codestyle.yamlcheck_title() function (enforces the rule); the violation itself is in the commit message of 5f127dc.

Suggested fix: Amend the commit message to remove the trailing period, then force-push the branch:

git commit --amend -m "BUILD: Resolve absolute prefix in cmake config"
git push --force-with-lease

This satisfies both the "no dot at the end" rule and the required BUILD: prefix convention, and will make the codestyle job pass.

Related: none

🛡️ This comment had 1 potential secret(s) redacted (Hex High Entropy String). See request_id 51e9e469-c7a6-44c4-a0e1-650f459741a2 in the triage console for the audit trail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants