BUILD: Resolve absolute prefix in cmake config. - #1314
Conversation
6e6a578 to
9ac7fae
Compare
|
/build |
9ac7fae to
5f127dc
Compare
|
Only changed the PR title and commit message to fit the |
|
/build |
|
@ci-triage-agent |
|
👀 Investigating |
|
🤖 CI Triage Agent — The logs are clear. I have a definitive root cause without needing any further investigation. Summary: Codestyle CI check failed because the commit title ends with a trailing period ( Root cause: The commit The CI script found exactly that and printed: Implicated commit: File: Suggested fix: Amend the commit message to remove the trailing period, then force-push the branch: git commit --amend -m "BUILD: Resolve absolute prefix in cmake config"
git push --force-with-leaseThis satisfies both the "no dot at the end" rule and the required Related: none
|
What
Resolve the install prefix to an absolute path in the imported CMake config.
Why ?
Current imported CMake targets contain deeply nested relative paths, i.e.
/path/to/install/lib/cmake/ucc/../../../lib/libucx.so. Resolving to an absolute path in the imported config gives a much cleaner path for the build system, i.e./path/to/install/lib/libucc.sowhile still keeping the config portable by leaving the prefix derivation from${CMAKE_CURENT_LIST_DIR}unchanged.This is also consistent with ucx-targets.cmake